Re: [Xenomai-core] [Xenomai-git] Jan Kiszka : RTDM: Split up application and driver debugging

[Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>]

Jan Kiszka wrote:
> Gilles Chanteperdrix wrote:
>> GIT version control wrote:
>>> Module: xenomai-jki
>>> Branch: for-upstream
>>> Commit: 134378c9ff2bc597aaa908564323afb744cbbf01
>>> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=134378c9ff2bc597aaa908564323afb744cbbf01
>>>
>>> Author: Jan Kiszka <jan.kiszka@domain.hid>
>>> Date:   Thu Feb  4 17:55:36 2010 +0100
>>>
>>> RTDM: Split up application and driver debugging
>>>
>>> There are use cases where you prefer to leave driver-level debugging
>>> checks on while preventing that user space can flood the log via unclean
>>> terminations. Split up the RTDM debug switch to reflect this.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
>>>
>>> ---
>>>
>>>  ksrc/skins/rtdm/Kconfig |    9 +++++++++
>>>  ksrc/skins/rtdm/core.c  |    2 +-
>>>  2 files changed, 10 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/ksrc/skins/rtdm/Kconfig b/ksrc/skins/rtdm/Kconfig
>>> index 5eeb2f3..f0741d6 100644
>>> --- a/ksrc/skins/rtdm/Kconfig
>>> +++ b/ksrc/skins/rtdm/Kconfig
>>> @@ -55,4 +55,13 @@ config XENO_OPT_DEBUG_RTDM
>>>  	It is a recommended option for analysing potential issues in RTDM
>>>  	drivers. A minor runtime overhead is added.
>>>  
>>> +config XENO_OPT_DEBUG_RTDM_APPL
>>> +	bool "RTDM application debugging support"
>>> +	depends on XENO_OPT_DEBUG
>>> +	default y
>>> +	help
>>> +
>>> +	When enabled, this option makes the RTDM skin warn about
>>> +	auto-clean operations executed upon application termination.
>>> +
>>>  endif
>>> diff --git a/ksrc/skins/rtdm/core.c b/ksrc/skins/rtdm/core.c
>>> index bc3dccc..3bc13f1 100644
>>> --- a/ksrc/skins/rtdm/core.c
>>> +++ b/ksrc/skins/rtdm/core.c
>>> @@ -396,7 +396,7 @@ void cleanup_owned_contexts(void *owner)
>>>  		xnlock_put_irqrestore(&rt_fildes_lock, s);
>>>  
>>>  		if (context) {
>>> -			if (XENO_DEBUG(RTDM))
>>> +			if (XENO_DEBUG(RTDM_APPL))
>>>  				xnprintf("RTDM: closing file descriptor %d.\n",
>>>  					 fd);
>> Are you sure you are not missing a hunk like this ?
>> #ifndef CONFIG_XENO_OPT_DEBUG_RTDM_APPL
>> #define CONFIG_XENO_OPT_DEBUG_RTDM_APPL        0
>> #endif /* CONFIG_XENO_OPT_DEBUG_RTDM_APPL */
>>
> 
> Of course - I wonder who designed this... :)
> 
> Just pushed v2.

Merged. Thanks.

-- 
					    Gilles.