From: Jiri Slaby <jirislaby@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>, Antti Palosaari <crope@iki.fi>,
mchehab@infradead.org, linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@redhat.com>,
linux-media@vger.kernel.org, Pekka Sarnila <sarnila@adit.fi>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes
Date: Thu, 04 Feb 2010 19:33:22 +0100 [thread overview]
Message-ID: <4B6B12F2.2080102@gmail.com> (raw)
In-Reply-To: <20100204181404.GC10965@core.coreip.homeip.net>
On 02/04/2010 07:14 PM, Dmitry Torokhov wrote:
> On Thu, Feb 04, 2010 at 11:31:45AM +0100, Jiri Slaby wrote:
> +
>> +static int dvb_event(struct hid_device *hdev, struct hid_field *field,
>> + struct hid_usage *usage, __s32 value)
>> +{
>> + /* we won't get a "key up" event */
>> + if (value) {
>> + input_event(field->hidinput->input, usage->type, usage->code, 1);
>> + input_event(field->hidinput->input, usage->type, usage->code, 0);
>
> Do not ever forget input_sync(), you need 2 of them here.
>
> With the latest changes to evdev, if you are using SIGIO you won't get
> wioken up until EV_SYN/SYN_REPORT.
HID layer syncs on its own. So the second is not needed. Why is needed
the first?
I.e. should there be one also in dvb_usb_read_remote_control?
next prev parent reply other threads:[~2010-02-04 18:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 17:19 [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes Jiri Slaby
2010-01-24 23:44 ` Antti Palosaari
2010-01-25 9:12 ` Jiri Slaby
2010-01-25 18:07 ` Antti Palosaari
2010-01-26 13:08 ` Jiri Kosina
2010-02-04 10:31 ` Jiri Slaby
2010-02-04 12:04 ` Mauro Carvalho Chehab
2010-02-04 12:53 ` Jiri Slaby
2010-02-04 13:41 ` Mauro Carvalho Chehab
2010-02-04 13:51 ` Jiri Slaby
2010-02-04 14:05 ` Mauro Carvalho Chehab
2010-02-05 14:02 ` Jarod Wilson
2010-02-04 14:26 ` Mauro Carvalho Chehab
2010-02-04 13:23 ` Pekka Sarnila
2010-02-04 13:27 ` Jiri Kosina
2010-02-04 14:07 ` Pekka Sarnila
2010-02-08 4:13 ` Greg KH
2010-02-04 14:04 ` Mauro Carvalho Chehab
2010-02-04 15:05 ` Pekka Sarnila
2010-02-04 17:13 ` Mauro Carvalho Chehab
2010-02-05 14:31 ` Pekka Sarnila
2010-02-04 18:14 ` Dmitry Torokhov
2010-02-04 18:33 ` Jiri Slaby [this message]
2010-02-04 18:41 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6B12F2.2080102@gmail.com \
--to=jirislaby@gmail.com \
--cc=crope@iki.fi \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mchehab@redhat.com \
--cc=sarnila@adit.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.