All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: Plugs race between the dc thread and an unlock ast message
Date: Thu, 04 Feb 2010 11:36:30 -0800	[thread overview]
Message-ID: <4B6B21BE.10708@oracle.com> (raw)
In-Reply-To: <20100204102729.GA4339@laptop.oracle.com>

Wengang Wang wrote:
> By "unlock ast message", do you meant
> ocfs2_locking_ast()->ocfs2_generic_handle_downconvert_action()?
>
> If yes, 
> if l_blocking did not changed before ocfs2_generic_handle_downconvert_action(),
> when l_level is set with a lower value, l_blocking must change.
> So why we need to check l_level?

I meant ocfs2_unlock_ast. Specifically cancel convert. That is one case
that does not change l_blocking directly.

However, that does not change the l_level too. So I am unsure what sequence
of asts and basts (multiple ofcourse) can lead to this situation.

But the patch looks reasonable even if I cannot state the precise scenario
that leads to it.

David is rerunning the test. We'll know the results by tomorrow.

  reply	other threads:[~2010-02-04 19:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-03 18:16 [Ocfs2-devel] [PATCH] ocfs2: Plugs race between the dc thread and an unlock ast message Sunil Mushran
2010-02-04 10:27 ` Wengang Wang
2010-02-04 19:36   ` Sunil Mushran [this message]
2010-02-05  6:01     ` Joel Becker
2010-02-05 18:39       ` Sunil Mushran
2010-02-05 19:33         ` Mark Fasheh
2010-02-05 23:37           ` Sunil Mushran
2010-02-09 20:55             ` David Teigland
2010-02-09 21:49               ` Sunil Mushran
2010-02-05 16:24     ` David Teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6B21BE.10708@oracle.com \
    --to=sunil.mushran@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.