From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH 2/3] cld: Add XDR files to gitignore
Date: Thu, 04 Feb 2010 17:30:30 -0500
Message-ID: <4B6B4A86.4090909@garzik.org>
References: <1265283057-30884-1-git-send-email-cmccabe@alumni.cmu.edu> <1265283057-30884-2-git-send-email-cmccabe@alumni.cmu.edu>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=Ew7PAy+GlvejCH4YEUCdztfbWPjefX93+insCGIyWjc=;
        b=VOdxVxEdTRN430sD0R0G6QQ8zXAYg0WLnGEhNoMUn8Mb4sxqQxjg391MZyaQA0wxRK
         bw9j6Zk5wJYRBcSYINGwsFoW0+CvisrMgnJ6TgHoBAX4n9ikx586ilRZqk2cohIsOQUE
         o/0yYlMOoHCGAcHSEt/yYdhr2OJ6vOijqUqso=
In-Reply-To: <1265283057-30884-2-git-send-email-cmccabe@alumni.cmu.edu>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Colin McCabe <cmccabe@alumni.cmu.edu>
Cc: Project Hail List <hail-devel@vger.kernel.org>, Pete Zaitcev <zaitcev@redhat.com>

On 02/04/2010 06:30 AM, Colin McCabe wrote:
> Signed-off-by: Colin McCabe<cmccabe@alumni.cmu.edu>
> ---
>   .gitignore |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)

While patch #1 seems OK at first glance, patches 2 and 3 definitely 
belong in the big XDR patch, because they refer to things not yet in the 
tree.

Cosmetic patches breaking lines or moving code around are fine, in 
preparation for an upcoming patch.  Those can be thought of as logically 
separate from the big XDR patch, even if they are -preparing- for said 
patch.  For example, I am thinking that the next move might be to move 
existing code into smaller functions as you did -- ie. accept_seqid() -- 
while still keeping the existing, pre-XDR code logic.  That makes the 
diff smaller, easier to read and review, while not specifically doing 
anything XDR related.

	Jeff