From: Cong Wang <amwang@redhat.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Peter Zijlstra <peterz@infradead.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Greg KH <gregkh@suse.de>, Thomas Gleixner <tglx@linutronix.de>,
Kernel development list <linux-kernel@vger.kernel.org>,
Tejun Heo <tj@kernel.org>, Miles Lane <miles.lane@gmail.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Patch 0/2] sysfs: fix s_active lockdep warning
Date: Fri, 05 Feb 2010 11:09:09 +0800 [thread overview]
Message-ID: <4B6B8BD5.8020404@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1002041337590.1261-100000@iolanthe.rowland.org>
Alan Stern wrote:
> On Thu, 4 Feb 2010, Peter Zijlstra wrote:
>
>> On Thu, 2010-02-04 at 11:35 -0500, Alan Stern wrote:
>>> +#include <linux/sched.h>
>> #include <linux/lockdep.h>
>>
>> should be sufficient I think.
>
> No, it's not. It leaves MAX_LOCK_DEPTH undeclared. Beats me why that
> symbol ended up in sched.h...
>
because task_struct->held_locks uses it, but it seems better to move
it into lockdep.h...
next prev parent reply other threads:[~2010-02-05 3:07 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 7:01 [Patch 0/2] sysfs: fix s_active lockdep warning Amerigo Wang
2010-01-29 7:02 ` [Patch 1/2] sysfs: add support for lockdep subclasses to s_active Amerigo Wang
2010-01-29 7:02 ` [PATCH 2/2] sysfs: fix the incomplete part of subclass support for s_active Amerigo Wang
2010-01-29 7:21 ` [Patch 0/2] sysfs: fix s_active lockdep warning Eric W. Biederman
2010-01-29 8:38 ` Cong Wang
2010-01-29 13:44 ` Eric W. Biederman
2010-01-29 14:22 ` Greg KH
2010-01-29 17:57 ` Peter Zijlstra
2010-01-29 18:10 ` Greg KH
2010-01-29 18:14 ` Peter Zijlstra
2010-01-29 18:21 ` Greg KH
2010-01-29 20:10 ` Peter Zijlstra
2010-01-29 20:30 ` Eric W. Biederman
2010-02-04 11:38 ` Peter Zijlstra
2010-02-04 16:35 ` Alan Stern
2010-02-04 16:41 ` Peter Zijlstra
2010-02-04 18:37 ` Alan Stern
2010-02-05 10:18 ` Peter Zijlstra
2010-02-05 15:30 ` Alan Stern
2010-02-05 15:41 ` Peter Zijlstra
2010-02-07 9:22 ` Dave Young
2010-02-08 3:08 ` Cong Wang
2010-02-08 3:14 ` Dave Young
2010-02-08 3:30 ` Cong Wang
2010-02-08 3:06 ` Cong Wang
2010-02-08 15:38 ` Alan Stern
2010-02-04 16:46 ` Peter Zijlstra
2010-02-04 18:40 ` Alan Stern
2010-02-05 3:09 ` Cong Wang [this message]
2010-02-05 4:06 ` Alan Stern
2010-02-04 16:46 ` Greg KH
2010-02-04 16:59 ` Thomas Gleixner
2010-02-26 19:36 ` Alan Stern
2010-02-26 20:54 ` Thomas Gleixner
2010-02-05 3:43 ` Cong Wang
2010-02-05 8:55 ` Eric W. Biederman
2010-01-29 20:25 ` Eric W. Biederman
2010-01-30 5:30 ` Greg KH
2010-01-29 18:02 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6B8BD5.8020404@redhat.com \
--to=amwang@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miles.lane@gmail.com \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.