All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: davem@davemloft.net, jonathan@jonmasters.org,
	eric.dumazet@gmail.com, netdev@vger.kernel.org,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH for 2.6.33] conntrack: restrict runtime hashsize 	modifications
Date: Fri, 05 Feb 2010 12:22:17 +0100	[thread overview]
Message-ID: <4B6BFF69.6050503@trash.net> (raw)
In-Reply-To: <b6fcc0a1002050319p2ba0ff30y4bc8bdba08ff65d9@mail.gmail.com>

Alexey Dobriyan wrote:
> On Fri, Feb 5, 2010 at 1:16 PM, Patrick McHardy <kaber@trash.net> wrote:
>> OK testing looks fine, although I'm quite surprised that its actually
>> possible to change module parameters from within non-init namespaces.
>> How is this supposed to work at all? I don't see how sysfs could
>> possibly provide a network namespace context ...
> 
> 
> You can do in write hook
> 
>     if (!net_eq(current->nsproxy->net_ns, &init_net))
>             return -EINVAL;

Right, I see. So we could actually make resizing work for all
namespaces quite easily. Is there any reason not to do this?

  reply	other threads:[~2010-02-05 11:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-03 20:39 [PATCH for 2.6.33] conntrack: restrict runtime hashsize modifications Alexey Dobriyan
2010-02-03 20:50 ` Jon Masters
2010-02-04 16:18 ` Patrick McHardy
2010-02-04 16:27   ` Patrick McHardy
2010-02-04 20:18     ` Jon Masters
2010-02-05 10:00       ` Patrick McHardy
2010-02-05 10:14         ` Jon Masters
2010-02-05 10:21           ` Patrick McHardy
2010-02-04 17:04   ` Patrick McHardy
2010-02-04 19:47     ` Alexey Dobriyan
2010-02-04 20:23       ` Jon Masters
2010-02-05 10:00       ` Patrick McHardy
2010-02-05 10:11         ` Jon Masters
2010-02-05 10:19           ` Patrick McHardy
2010-02-05 11:16         ` Patrick McHardy
2010-02-05 11:19           ` Alexey Dobriyan
2010-02-05 11:22             ` Patrick McHardy [this message]
2010-02-05 11:25               ` Patrick McHardy
2010-02-05 11:51               ` Jon Masters
2010-02-05 11:23             ` Alexey Dobriyan
2010-02-05 22:04         ` Alexey Dobriyan
2010-02-08 13:34           ` Patrick McHardy
2010-02-08 14:35             ` Patrick McHardy
2010-02-04 20:20     ` Jon Masters
2010-02-05 10:03       ` Patrick McHardy
2010-02-05 10:12         ` Jon Masters
2010-02-05 10:21           ` Patrick McHardy
2010-02-04 17:26 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6BFF69.6050503@trash.net \
    --to=kaber@trash.net \
    --cc=adobriyan@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jonathan@jonmasters.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.