From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: "Hebbar, Shivananda" <x0hebbar@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [Patch 8/8] DSPBRIDGE: typedef cleanup -CHNL_MODE
Date: Fri, 5 Feb 2010 16:32:54 -0600 [thread overview]
Message-ID: <4B6C9C96.3010900@ti.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E7394044A6B9678@dbde02.ent.ti.com>
Hi,
On 2/2/2010 6:44 PM, Hebbar, Shivananda wrote:
> From 23b8b63a9f57c20b3f87ac886623d227d5448e8f Mon Sep 17 00:00:00 2001
> From: Shivananda Hebbar<x0hebbar@ti.com>
> Date: Thu, 28 Jan 2010 20:53:48 -0600
> Subject: [PATCH] DSPBRIDGE: Remove typedef CHNL_MODE and replace it with
> normal C type
>
> This patch removes the typedef CHNL_MODE.
> CHNL_MODE values are well within the range of short int.
> Hence changing it from u32 type to short int.
>
> Signed-off-by: Shivananda Hebbar<x0hebbar@ti.com>
> ---
> arch/arm/plat-omap/include/dspbridge/chnldefs.h | 2 --
> arch/arm/plat-omap/include/dspbridge/wmd.h | 2 +-
> arch/arm/plat-omap/include/dspbridge/wmdchnl.h | 2 +-
> drivers/dsp/bridge/rmgr/node.c | 2 +-
> drivers/dsp/bridge/rmgr/strm.c | 2 +-
> drivers/dsp/bridge/wmd/chnl_sm.c | 8 ++++----
> 6 files changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/dspbridge/chnldefs.h b/arch/arm/plat-omap/include/dspbridge/chnldefs.h
> index be405ba..43df8b7 100644
> --- a/arch/arm/plat-omap/include/dspbridge/chnldefs.h
> +++ b/arch/arm/plat-omap/include/dspbridge/chnldefs.h
> @@ -45,8 +45,6 @@
> #define CHNL_IsIOCancelled(ioc) (ioc.status& CHNL_IOCSTATCANCEL)
> #define CHNL_IsTimedOut(ioc) (ioc.status& CHNL_IOCSTATTIMEOUT)
>
> -/* CHNL types: */
> - typedef u32 CHNL_MODE; /* Channel transfer mode. */
>
> /* Channel attributes: */
> struct CHNL_ATTRS {
> diff --git a/arch/arm/plat-omap/include/dspbridge/wmd.h b/arch/arm/plat-omap/include/dspbridge/wmd.h
> index 70f3970..95c79f2 100644
> --- a/arch/arm/plat-omap/include/dspbridge/wmd.h
> +++ b/arch/arm/plat-omap/include/dspbridge/wmd.h
> @@ -418,7 +418,7 @@ typedef DSP_STATUS(*WMD_BRD_WRITE)(struct WMD_DEV_CONTEXT *hDevContext,
> typedef DSP_STATUS(*WMD_CHNL_OPEN) (OUT struct CHNL_OBJECT
> **phChnl,
> struct CHNL_MGR *hChnlMgr,
> - CHNL_MODE uMode,
> + short int chnlMode,
changing name of variable breaks compilation
> u32 uChnlId,
> CONST IN OPTIONAL struct
> CHNL_ATTRS *pAttrs);
> diff --git a/arch/arm/plat-omap/include/dspbridge/wmdchnl.h b/arch/arm/plat-omap/include/dspbridge/wmdchnl.h
> index 4b733d8..9e73516 100644
> --- a/arch/arm/plat-omap/include/dspbridge/wmdchnl.h
> +++ b/arch/arm/plat-omap/include/dspbridge/wmdchnl.h
> @@ -33,7 +33,7 @@
>
> extern DSP_STATUS WMD_CHNL_Open(OUT struct CHNL_OBJECT **phChnl,
> struct CHNL_MGR *hChnlMgr,
> - CHNL_MODE uMode,
> + short int chnlMode,
> u32 uChnlId,
> CONST IN OPTIONAL struct CHNL_ATTRS
> *pAttrs);
> diff --git a/drivers/dsp/bridge/rmgr/node.c b/drivers/dsp/bridge/rmgr/node.c index 5352923..538c806 100644
> --- a/drivers/dsp/bridge/rmgr/node.c
> +++ b/drivers/dsp/bridge/rmgr/node.c
> @@ -895,7 +895,7 @@ DSP_STATUS NODE_Connect(struct NODE_OBJECT *hNode1, u32 uStream1,
> struct STREAM *pStream;
> GB_BitNum pipeId = GB_NOBITS;
> GB_BitNum chnlId = GB_NOBITS;
> - CHNL_MODE uMode;
> + short int uMode;
> u32 dwLength;
> DSP_STATUS status = DSP_SOK;
> DBC_Require(cRefs> 0);
> diff --git a/drivers/dsp/bridge/rmgr/strm.c b/drivers/dsp/bridge/rmgr/strm.c index febb6c2..f03064e 100644
> --- a/drivers/dsp/bridge/rmgr/strm.c
> +++ b/drivers/dsp/bridge/rmgr/strm.c
> @@ -524,7 +524,7 @@ DSP_STATUS STRM_Open(struct NODE_OBJECT *hNode, u32 uDir, u32 uIndex,
> struct WMD_DRV_INTERFACE *pIntfFxns;
> u32 ulChnlId;
> struct STRM_OBJECT *pStrm = NULL;
> - CHNL_MODE uMode;
> + short int uMode;
> struct CHNL_ATTRS chnlAttrs;
> DSP_STATUS status = DSP_SOK;
> struct CMM_OBJECT *hCmmMgr = NULL; /* Shared memory manager hndl */
> diff --git a/drivers/dsp/bridge/wmd/chnl_sm.c b/drivers/dsp/bridge/wmd/chnl_sm.c
> index ca5662d..5d3f71e 100644
> --- a/drivers/dsp/bridge/wmd/chnl_sm.c
> +++ b/drivers/dsp/bridge/wmd/chnl_sm.c
> @@ -253,7 +253,7 @@ DSP_STATUS WMD_CHNL_CancelIO(struct CHNL_OBJECT *hChnl)
> DSP_STATUS status = DSP_SOK;
> struct CHNL_OBJECT *pChnl = (struct CHNL_OBJECT *)hChnl;
> u32 iChnl = -1;
> - CHNL_MODE uMode;
> + short int chnlMode;
here
> struct CHNL_IRP *pChirp;
> struct CHNL_MGR *pChnlMgr = NULL;
>
> @@ -483,7 +483,7 @@ DSP_STATUS WMD_CHNL_FlushIO(struct CHNL_OBJECT *hChnl, u32 dwTimeOut) {
> DSP_STATUS status = DSP_SOK;
> struct CHNL_OBJECT *pChnl = (struct CHNL_OBJECT *)hChnl;
> - CHNL_MODE uMode = -1;
> + short int chnlMode = -1;
and here
> struct CHNL_MGR *pChnlMgr;
> struct CHNL_IOC chnlIOC;
> /* Check args: */
> @@ -758,7 +758,7 @@ DSP_STATUS WMD_CHNL_GetMgrInfo(struct CHNL_MGR *hChnlMgr, u32 uChnlID, DSP_STATUS WMD_CHNL_Idle(struct CHNL_OBJECT *hChnl, u32 dwTimeOut,
> bool fFlush)
> {
> - CHNL_MODE uMode;
> + short int uMode;
> struct CHNL_MGR *pChnlMgr;
> DSP_STATUS status = DSP_SOK;
>
> @@ -786,7 +786,7 @@ DSP_STATUS WMD_CHNL_Idle(struct CHNL_OBJECT *hChnl, u32 dwTimeOut,
> * Open a new half-duplex channel to the DSP board.
> */
> DSP_STATUS WMD_CHNL_Open(OUT struct CHNL_OBJECT **phChnl,
> - struct CHNL_MGR *hChnlMgr, CHNL_MODE uMode,
> + struct CHNL_MGR *hChnlMgr, short int chnlMode,
and here
> u32 uChnlId, CONST IN struct CHNL_ATTRS *pAttrs) {
> DSP_STATUS status = DSP_SOK;
> --
> 1.6.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
- omar
next prev parent reply other threads:[~2010-02-05 22:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 0:44 [Patch 8/8] DSPBRIDGE: typedef cleanup -CHNL_MODE Hebbar, Shivananda
2010-02-05 22:32 ` Omar Ramirez Luna [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-06 1:24 Hebbar, Shivananda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6C9C96.3010900@ti.com \
--to=omar.ramirez@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=x0hebbar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.