All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Stigge <stigge@domain.hid>
To: Xenomai core <Xenomai-core@domain.hid>
Cc: Jan Kiszka <jan.kiszka@domain.hid>
Subject: [Xenomai-core] Xenomai in Debian
Date: Sun, 07 Feb 2010 10:01:27 +0100	[thread overview]
Message-ID: <4B6E8167.6010907@domain.hid> (raw)

[-- Attachment #1: Type: text/plain, Size: 804 bytes --]

Hi,

I'm just working on the Xenomai 2.5.1 Debian package and encountered 
non-PIC code (evil! ;-) in the shared libraries (skins libraries).

You can see it with e.g.

$ readelf -d src/skins/native/.libs/libnative.so.3.0.0

The "TEXTREL" tag indicates non-PIC code.

$ scanelf -qT src/skins/native/.libs/libnative.so.3.0.0

Shows the function and code offset of the relocation.

With

$ objdump -d src/skins/native/.libs/libnative.so.3.0.0

I found the actual location of the relocation.

I prepared a patch (attached) that fixes it: First, the relocation 
itself by letting GCC create the address in PIC style. Second, "extern 
inline" looks a bit counterintuitive at first, but according to the GCC 
manual, it seems to be what we want (macro behaviour).

Thanks Jan for reminding me!

bye,
   Roland

[-- Attachment #2: xenomai.patch --]
[-- Type: text/x-patch, Size: 414 bytes --]

--- xenomai-2.5.1.orig/include/asm-x86/syscall.h
+++ xenomai-2.5.1/include/asm-x86/syscall.h
@@ -161,9 +161,11 @@
      ".endif\n\t"
      ".endm\n\t");
 
-static inline void __xn_get_eip(void **dest)
+__attribute__((always_inline))
+extern inline void __xn_get_eip(void **dest)
 {
-        asm volatile("movl $1f, %0; 1:": "=m"(*dest));
+addr:
+	*dest = &&addr;
 }
 
 static inline void __xn_get_ebp(void **dest)

             reply	other threads:[~2010-02-07  9:01 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-07  9:01 Roland Stigge [this message]
2010-02-07 14:24 ` [Xenomai-core] Xenomai in Debian Gilles Chanteperdrix
2010-02-13 14:32 ` Gilles Chanteperdrix
2010-02-13 15:07   ` Roland Stigge
2010-02-13 15:25     ` Gilles Chanteperdrix
2010-02-13 18:30       ` Jan Kiszka
2010-02-13 18:37         ` Gilles Chanteperdrix
2010-02-13 18:48           ` Jan Kiszka
2010-02-13 21:15             ` Gilles Chanteperdrix
2010-02-14  9:38     ` Philippe Gerum
2010-02-23 16:52       ` Stefan Kisdaroczi
2010-02-23 17:46         ` Philippe Gerum
2010-02-24 13:06           ` Stefan Kisdaroczi
2010-02-24 13:11             ` Philippe Gerum
2010-02-24 13:13               ` Philippe Gerum
2010-02-26 13:13                 ` Stefan Kisdaroczi
2010-02-26 13:28                   ` Philippe Gerum
2010-02-26 13:48                     ` Stefan Kisdaroczi
2010-02-26 14:07                       ` Philippe Gerum
2010-03-03 16:54                         ` Stefan Kisdaroczi
2010-03-03 17:21                           ` Philippe Gerum
2010-02-25 12:46             ` Stefan Kisdaroczi
2010-02-25 13:44       ` Stefan Kisdaroczi
2010-02-25 13:49         ` Gilles Chanteperdrix
2010-02-25 13:59           ` Stefan Kisdaroczi
2010-02-25 14:29             ` Stefan Kisdaroczi
2010-02-25 17:18               ` Stefan Kisdaroczi
2010-02-26 13:35                 ` Stefan Kisdaroczi
2010-05-02 16:01                   ` Roland Stigge
     [not found]             ` <4B868CC1.6030103@domain.hid>
2010-02-25 18:31               ` Stefan Kisdaroczi
2010-02-25 13:59           ` Jan Kiszka
2010-03-01 17:04     ` Gilles Chanteperdrix
2010-03-01 21:45       ` Roland Stigge
  -- strict thread matches above, loose matches on Subject: below --
2008-02-26  8:25 Roland Stigge
2008-02-26 10:26 ` Gilles Chanteperdrix
2008-02-26 10:43   ` Roland Stigge
2008-02-26 13:20     ` Gilles Chanteperdrix
2008-02-26 15:32       ` Roland Stigge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6E8167.6010907@domain.hid \
    --to=stigge@domain.hid \
    --cc=Xenomai-core@domain.hid \
    --cc=jan.kiszka@domain.hid \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.