From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm <kvm@vger.kernel.org>
Subject: Re: KVM: VMX: update cr0 read shadow when deactivating cr0.ts passthrough
Date: Sun, 07 Feb 2010 13:53:46 +0200 [thread overview]
Message-ID: <4B6EA9CA.3060202@redhat.com> (raw)
In-Reply-To: <20100201164827.GA3225@amt.cnet>
On 02/01/2010 06:48 PM, Marcelo Tosatti wrote:
> On fpu deactivation, the cr0 read shadow is not properly updated, since
> it assumes vcpu->arch.cr0 contains the guest visible cr0 value before
> guest had control of cr0.ts.
>
> This is not true, since cr0 has been decached (from vmx_fpu_deactivate
> itself or somewhere else).
>
> Fix by unconditionally updating cr0 read shadow (this is not a hot path,
> in comparison with entry/exit).
>
> Fixes FC8 64 install.
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-02-07 11:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 16:48 KVM: VMX: update cr0 read shadow when deactivating cr0.ts passthrough Marcelo Tosatti
2010-02-07 11:53 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6EA9CA.3060202@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.