From: Albert Herranz <albert_herranz@yahoo.es>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: USB list <linux-usb@vger.kernel.org>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH 1/2] USB: add HCD_BOUNCE_BUFFERS host controller driver flag
Date: Sun, 07 Feb 2010 19:10:49 +0100 [thread overview]
Message-ID: <4B6F0229.5070604@yahoo.es> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1002031429430.1321-100000@iolanthe.rowland.org>
Alan Stern wrote:
>On a 64-bit processor, some of the accesses will be 64 bits wide
>instead of 32. Does that matter for your purposes?
>
The wii uses a 32-bit processor, so this is safe in this case.
>What about ohci-hcd and uhci-hcd? They both use non-32-bit accesses to
>structures in coherent memory.
>
The wii has no uhci, but has 2 ohci controllers.
For ohci we need a similar approach as done for ehci.
>If you do it as described above then the buffers you're worried about
>won't be allocated in coherent memory to begin with, so no problems
>will arise.
It turns out that we have more limitations.
The wii has 2 discontiguous memory areas (usually called MEM1 and MEM2). I have checked that the ehci controller doesn't work properly when performing dma to buffers allocated in MEM1 (it corrupts part of the data) but has no problems if the buffers sit within MEM2.
So usb buffers will need to be bounced anyway if they are part of MEM1.
This worked in the original patch as buffers were always bounced to MEM2 buffers. Sigh.
>Alan Stern
>
Thanks,
Albert
PS: Your reply didn't get to me. I looked at the ML and found it (I'm not subscribed). Sorry for the late answer.
next prev parent reply other threads:[~2010-02-07 18:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 18:30 [RFC PATCH 0/2] wii: add usb 2.0 support Albert Herranz
2010-02-03 18:30 ` [RFC PATCH 1/2] USB: add HCD_BOUNCE_BUFFERS host controller driver flag Albert Herranz
2010-02-03 19:00 ` Greg KH
2010-02-03 19:40 ` Alan Stern
2010-02-04 18:23 ` Albert Herranz
2010-02-04 18:58 ` Alan Stern
2010-02-07 18:10 ` Albert Herranz [this message]
2010-02-07 20:26 ` Alan Stern
2010-02-07 23:38 ` Albert Herranz
2010-02-03 18:30 ` [RFC PATCH 2/2] wii: hollywood ehci controller support Albert Herranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6F0229.5070604@yahoo.es \
--to=albert_herranz@yahoo.es \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.