From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] edb93xx: enable the uart in devicecfg register
Date: Sun, 07 Feb 2010 17:08:51 -0600 [thread overview]
Message-ID: <4B6F4803.6080201@windriver.com> (raw)
In-Reply-To: <20100206222402.GC15617@darwin>
Matthias Kaehlcke wrote:
> Hi Alessandro,
>
> El Sat, Feb 06, 2010 at 08:54:05PM +0100 Alessandro Rubini ha dit:
>
>> printf goes to uart1, but it will block forever waiting for
>> busy to go off unless the uart is enabled first.
>>
>> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
>> ---
>> board/edb93xx/edb93xx.c | 6 ++++++
>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/board/edb93xx/edb93xx.c b/board/edb93xx/edb93xx.c
>> index 4df2246..dde30ff 100644
>> --- a/board/edb93xx/edb93xx.c
>> +++ b/board/edb93xx/edb93xx.c
>> @@ -64,6 +64,12 @@ int board_init(void)
>> value |= SYSCON_PWRCNT_UART_BAUD;
>> writel(value, &syscon->pwrcnt);
>>
>> + /* Enable the uart in devicecfg */
>> + value = readl(&syscon->devicecfg);
>> + value |= 1<<18 /* U1EN */;
>
> using a constant like DEVCFG_U1EN would be preferrable, as the patch
> is correct at the functional and coding style level i'll leave it to
> Tom to decide if we fix this now or later
>
It is ok to fix this later.
The patch set have been applied.
Thanks
Tom
next prev parent reply other threads:[~2010-02-07 23:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-06 19:53 [U-Boot] [PATCH 0/3] Fixes for edb9315 Alessandro Rubini
2010-02-06 19:53 ` [U-Boot] [PATCH 1/3] EP93xx: fix syscon_regs definition Alessandro Rubini
2010-02-06 22:17 ` Matthias Kaehlcke
2010-02-06 19:53 ` [U-Boot] [PATCH 2/3] edb93xx: change calculation un early_udelay.h Alessandro Rubini
2010-02-06 22:17 ` Matthias Kaehlcke
2010-02-06 19:54 ` [U-Boot] [PATCH 3/3] edb93xx: enable the uart in devicecfg register Alessandro Rubini
2010-02-06 22:24 ` Matthias Kaehlcke
2010-02-07 23:08 ` Tom [this message]
2010-02-06 22:15 ` [U-Boot] [PATCH 0/3] Fixes for edb9315 Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6F4803.6080201@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.