All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Oberritter <obi@linuxtv.org>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Francesco Lavra <francescolavra@interfree.it>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH] dvb-core: fix initialization of feeds list in demux filter
Date: Mon, 08 Feb 2010 13:24:39 +0100	[thread overview]
Message-ID: <4B700287.5080900@linuxtv.org> (raw)
In-Reply-To: <4B6F72E5.3040905@redhat.com>

Hello Mauro,

Mauro Carvalho Chehab wrote:
> Good catch, but it seems better to initialize both the mutex and the list head
> at dvb_dmx_dev_init. Please test if the following patch fixes the issue. If so, please
> sign.

please apply Francesco's original patch. Yours won't work, because
"feed" is a union. It must be initialized each time DMX_SET_PES_FILTER
gets called, because the memory might have been overwritten by a
previous call to DMX_SET_FILTER, which uses "feed.sec".

Regards,
Andreas

  reply	other threads:[~2010-02-08 12:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-07 12:49 [PATCH] dvb-core: fix initialization of feeds list in demux filter Francesco Lavra
2010-02-07 15:13 ` Andy Walls
2010-02-07 21:21   ` hermann pitton
2010-02-08  2:11 ` Mauro Carvalho Chehab
2010-02-08 12:24   ` Andreas Oberritter [this message]
2010-02-08 13:43     ` [PATCH] dvb-core: fix initialization of feeds list in demux filter (Was: Videotext application crashes the kernel due to DVB-demux patch) Chicken Shack
2010-02-08 16:14       ` Linus Torvalds
2010-02-08 17:22         ` Mauro Carvalho Chehab
2010-02-08 18:25         ` Chicken Shack
2010-02-08 19:09           ` Linus Torvalds
2010-02-08 19:20             ` Chicken Shack
2010-02-08 23:30               ` Rudy Zijlstra
     [not found]           ` <E1NeyGg-0000ze-FG@fencepost.gnu.org>
2010-02-09 22:34             ` Chicken Shack
2010-02-09  0:53         ` hermann pitton
2010-02-09  8:38           ` Chicken Shack
2010-02-11  0:50             ` hermann pitton
2010-02-08 16:15       ` Devin Heitmueller
2010-02-08 18:01       ` Alain Kalker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B700287.5080900@linuxtv.org \
    --to=obi@linuxtv.org \
    --cc=francescolavra@interfree.it \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.