Re: [PATCH 8/12] tm6000: add tuner parameter

[Stefan Ringel <stefan.ringel@arcor.de>]

Am 08.02.2010 16:55, schrieb Stefan Ringel:
> Am 08.02.2010 03:55, schrieb Mauro Carvalho Chehab:
>   
>> stefan.ringel@arcor.de wrote:
>>
>>   
>>     
>>> +		ctl.vhfbw7 = 1;
>>> +		ctl.uhfbw8 = 1;
>>>     
>>>       
>> I don't think you need to set this, as the driver will automatically do the firmware
>> tricks for the firmwares. This will probably just change the default to start
>> wit firmware 7/8.
>>
>>   
>>     
> if it's going to bw 7 it doesn't use DTV 7, it's use DTV 7 not DTV78, I
> have it tested. I think if it's switch between DTV7 and DTV 8 it's not
> always set DTV78. ( it's set DTV 7 DTV 8 or DTV78)
>
>   

    switch (bw) {
    case BANDWIDTH_8_MHZ:
        if (p->frequency < 470000000)
            priv->ctrl.vhfbw7 = 0;
        else
            priv->ctrl.uhfbw8 = 1;
        type |= (priv->ctrl.vhfbw7 && priv->ctrl.uhfbw8) ? DTV78 : DTV8;
        type |= F8MHZ;
        break;
    case BANDWIDTH_7_MHZ:
        if (p->frequency < 470000000)
            priv->ctrl.vhfbw7 = 1;
        else
            priv->ctrl.uhfbw8 = 0;
        type |= (priv->ctrl.vhfbw7 && priv->ctrl.uhfbw8) ? DTV78 : DTV7;
        type |= F8MHZ;
        break;
    case BANDWIDTH_6_MHZ:
        type |= DTV6;
        priv->ctrl.vhfbw7 = 0;
        priv->ctrl.uhfbw8 = 0;
        break;
    default:
        tuner_err("error: bandwidth not supported.\n");
    };

That is the actually part from tuner-xc2028.c, but I think here is the
checking wrong if Bandwidth 8 MHz & frequency < 470 MHz then DTV8, and
if Bandwidth 7 MHz & frequency => 470 MHz then DTV7. The first check in
code is OK, but the second check in code is not OK.

-- 
Stefan Ringel <stefan.ringel@arcor.de>