From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [PATCH 5/9] use ckpt_err for architecture mismatch errors Date: Mon, 08 Feb 2010 22:52:25 -0500 Message-ID: <4B70DBF9.30105@cs.columbia.edu> References: <1265680806-13295-1-git-send-email-serue@us.ibm.com> <1265680806-13295-6-git-send-email-serue@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1265680806-13295-6-git-send-email-serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org List-Id: containers.vger.kernel.org serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org wrote: > From: Serge E. Hallyn > > Signed-off-by: Serge E. Hallyn > --- > arch/x86/kernel/checkpoint.c | 4 +++- > checkpoint/restart.c | 18 ++++++++++++++---- > 2 files changed, 17 insertions(+), 5 deletions(-) > [...] > diff --git a/checkpoint/restart.c b/checkpoint/restart.c > index fcd07fa..9bb17fc 100644 > --- a/checkpoint/restart.c > +++ b/checkpoint/restart.c > @@ -569,12 +569,14 @@ static int check_kernel_const(struct ckpt_const *h) > return -EINVAL; > if (h->uts_nodename_len != sizeof(uts->nodename)) > return -EINVAL; > +#if 0 > if (h->uts_release_len != sizeof(uts->release)) > return -EINVAL; > if (h->uts_version_len != sizeof(uts->version)) > return -EINVAL; > if (h->uts_machine_len != sizeof(uts->machine)) > return -EINVAL; > +#endif What is the purpose of this ? I thought these sizes do not depends on the kernel bit-ness. > if (h->uts_domainname_len != sizeof(uts->domainname)) > return -EINVAL; > /* rlimit */ [...] Oren.