All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <junio@kernel.org>
Subject: Re: [PATCH] blame: prevent a segv when -L given start > EOF
Date: Tue, 09 Feb 2010 08:43:43 +0100	[thread overview]
Message-ID: <4B71122F.3040809@viscovery.net> (raw)
In-Reply-To: <1265687293-11168-1-git-send-email-jaysoffian@gmail.com>

Jay Soffian schrieb:
> +test_expect_success 'blame -L with invalid start' '
> +	test_must_fail git blame -L5 tres 2>&1 | grep "has only 2 lines"

Please write this as

	test_must_fail git blame -L5 tres >output 2>&1 &&
	grep "has only 2 lines" output

> +'
> +
> +test_expect_success 'blame -L with invalid end' '
> +	git blame -L1,5 tres 2>&1 | grep "has only 2 lines"

	test_must_fail git blame -L1,5 tres >output 2>&1 &&
	grep "has only 2 lines" output

because shells look only at the exit code of the last command in a pipeline.

-- Hannes

  parent reply	other threads:[~2010-02-09  7:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-09  3:48 [PATCH] blame: prevent a segv when -L given start > EOF Jay Soffian
2010-02-09  3:50 ` Jay Soffian
2010-02-09  3:55 ` Junio C Hamano
2010-02-09  4:00   ` Jay Soffian
2010-02-09  4:02     ` Jay Soffian
2010-02-09  4:09   ` Jay Soffian
2010-02-09  5:55   ` Junio C Hamano
2010-02-09  7:43 ` Johannes Sixt [this message]
2010-02-09 17:55   ` Jay Soffian
2010-02-09 18:06     ` Junio C Hamano
2010-02-09 17:59   ` [PATCH v2] " Jay Soffian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B71122F.3040809@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=jaysoffian@gmail.com \
    --cc=junio@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.