All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
To: ext Herbert Xu <herbert@gondor.apana.org.au>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: crypto_shash_update & CRYPTO_TFM_REQ_MAY_SLEEP
Date: Tue, 09 Feb 2010 10:45:31 +0200	[thread overview]
Message-ID: <4B7120AB.8010201@nokia.com> (raw)
In-Reply-To: <20100209074146.GA17681@gondor.apana.org.au>

Hi,

Ok...

But normally kernel client code uses sync API as shash.

And I provide async hw driver via async ahash API.
That is simply will not be used at all.

Client must be changed to use async ahash API in order to benefit from
HW crypto.

Right?

Thanks,
Dmitry


ext Herbert Xu wrote:
> Dmitry Kasatkin <dmitry.kasatkin@nokia.com> wrote:
>   
>> One interesting issue
>>
>> Many clients in the kernel set CRYPTO_TFM_REQ_MAY_SLEEP to desc.flags.
>> It is used by crypto_yeld().
>>     
>
> That flag is really only meaningful for synchronous implementations.
>
> For hardware crypto that is asynchronous, you can simply ignore it
> in most cases (exceptions include invoking a syncrhonous backup, for
> example).
>
> Cheers,
>   

  reply	other threads:[~2010-02-09  8:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-03 17:21 crypto_shash_update & CRYPTO_TFM_REQ_MAY_SLEEP Dmitry Kasatkin
2010-02-09  7:41 ` Herbert Xu
2010-02-09  8:45   ` Dmitry Kasatkin [this message]
2010-02-09  9:02     ` Herbert Xu
2010-02-10 12:16   ` Dmitry Kasatkin
2010-02-15 19:20     ` Dmitry Kasatkin
2010-02-16  0:44       ` Herbert Xu
2010-02-16  6:36         ` Dmitry Kasatkin
2010-02-16  6:58           ` Herbert Xu
2010-02-16  7:05             ` Dmitry Kasatkin
2010-02-16  7:27               ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7120AB.8010201@nokia.com \
    --to=dmitry.kasatkin@nokia.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.