From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NengB-0008JL-ER
	for qemu-devel@nongnu.org; Tue, 09 Feb 2010 05:50:51 -0500
Received: from [199.232.76.173] (port=46255 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Neng9-0008Iy-Ly
	for qemu-devel@nongnu.org; Tue, 09 Feb 2010 05:50:49 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <ian.molton@collabora.co.uk>)
	id 1Neng8-0005qE-Ii
	for qemu-devel@nongnu.org; Tue, 09 Feb 2010 05:50:49 -0500
Received: from bhuna.collabora.co.uk ([93.93.128.226]:36023)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ian.molton@collabora.co.uk>) id 1Neng8-0005q4-8D
	for qemu-devel@nongnu.org; Tue, 09 Feb 2010 05:50:48 -0500
Message-ID: <4B713DDA.1040404@collabora.co.uk>
Date: Tue, 09 Feb 2010 10:50:02 +0000
From: Ian Molton <ian.molton@collabora.co.uk>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/5] virtio: Add virtio-rng driver
References: <1265031265-14717-1-git-send-email-ian.molton@collabora.co.uk>	<1265031265-14717-2-git-send-email-ian.molton@collabora.co.uk>	<1265031265-14717-3-git-send-email-ian.molton@collabora.co.uk>	<1265031265-14717-4-git-send-email-ian.molton@collabora.co.uk>	<1265031265-14717-5-git-send-email-ian.molton@collabora.co.uk>	<4B66F3C9.6090103@codemonkey.ws>
	<4B675A2C.7030207@collabora.co.uk>
In-Reply-To: <4B675A2C.7030207@collabora.co.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

Ian Molton wrote:

>>> +static void virtio_rng_save(QEMUFile *f, void *opaque)
>>> +{
>>> +    VirtIORng *s = opaque;
>>> +
>>> +    virtio_save(&s->vdev, f);
>>> +}
>>> +
>>> +static int virtio_rng_load(QEMUFile *f, void *opaque, int version_id)
>>> +{
>>> +    VirtIORng *s = opaque;
>>> +
>>> +    if (version_id != 1)
>>> +        return -EINVAL;
>>> +
>>> +    virtio_load(&s->vdev, f);
>>> +    return 0;
>>> +}
>>>
>>>    
>> This doesn't look correct to me.  There is absolutely no state
>> maintained by the virtio-rng backend?  I find that hard to believe.
> 
> What state needs maintaining? when it runs out of entropy, it simply
> reconnects. Unless I misunderstood what those functions are for...

ping?