From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH] [PVOPS] fix gntdev on PAE Date: Tue, 09 Feb 2010 14:24:42 -0800 Message-ID: <4B71E0AA.3010209@goop.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini Cc: Ian Campbell , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 02/01/2010 07:46 AM, Stefano Stabellini wrote: > On Mon, 1 Feb 2010, Stefano Stabellini wrote: > >> Hi all, >> this small patch fixes gntdev on Linux pvops kernels: >> gnttab_set_map_op and gnttab_set_unmap_op shouldn't take unsigned long >> as parameters for machine addresses because they are not big enough on >> PAE systems. >> This patch fixes the issue using phys_addr_t instead and enables >> XEN_GNTDEV compilation again. >> >> >> Signed-off-by: Stefano Stabellini >> >> > BTW gntdev is used by qemu to provide the console backend to pv guests. > I applied the grant_table.h parts of the patch since its clearly a fix, but I think we need confirm that gnt_dev is really OK. J