From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [Patch 1/1] CLD: regression in unified cld_timer
Date: Tue, 09 Feb 2010 17:51:04 -0500
Message-ID: <4B71E6D8.7000402@garzik.org>
References: <20100209100210.2ba1dda5@redhat.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=JMw8gWWSJ1Y4c7tk6jSbyaa4xN2h58Nni/TjVd+QqwE=;
        b=X/qBT09R+aADmCz5jPdVhjrmI2LbBIB8SW47UFeQzo10n1efxNy1W47DEe0ImSSNC2
         vbuALrSnfyArLoqxjWYiHl4ieEJf9N455Odjwbzc899XgXReK63EZKwUiVBbn54PUNYp
         eyXwXK0sBlPVjQD2J39eAegv9PwZWKJE4f95o=
In-Reply-To: <20100209100210.2ba1dda5@redhat.com>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>

On 02/09/2010 12:02 PM, Pete Zaitcev wrote:
> The common timer implementation had a bug whereas it overwrote the list
> of timers when a timer callback added its own timer -- which just about
> every one of them does. The most visible result was that sessions stopped
> expiring correctly and left dangling file locks. Also, every new session
> failed after 2 minutes 35 seconds.
>
> The fix is not to keep a local copy of the list head across invocations
> of the callback.
>
> Signed-Off-By: Pete Zaitcev<zaitcev@redhat.com>
>
> ---
>   lib/libtimer.c |    5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> Jeff&  Colin: sorry to waste your time with inferences that the change
> to XDR was somehow involved. I guess I did not update the CLD on the
> server since before the common timer.

applied