From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCHv2] cld: use XDR for all messages
Date: Tue, 09 Feb 2010 18:21:02 -0500
Message-ID: <4B71EDDE.6070209@garzik.org>
References: <1263577788-2081-1-git-send-email-cmccabe@alumni.cmu.edu>	<4B7128FB.90600@garzik.org>	<4B712D0D.5060408@garzik.org> <20100209161306.5e312b28@redhat.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=O0uOGN96dIW14/SZDoNQnKw8QID78ZyjCD026S5aCk0=;
        b=ep9tdoSqZhD1ZSMJnX1mzR9JKPSsazgP7TKmykivfq2ii+2ghEjs/YeePJGOnMmb64
         K+FJSpsg1CnKIsmz9ZqZv1apgLtfZT1/xtwbnE5eiSPr+bHKVIDAaeaFtxfyEtsjq5YZ
         4T6dZS/1DRXw8GHK2oMyp8Yn4rfsO98tLeB/0=
In-Reply-To: <20100209161306.5e312b28@redhat.com>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Colin McCabe <cmccabe@alumni.cmu.edu>, Project Hail List <hail-devel@vger.kernel.org>

On 02/09/2010 06:13 PM, Pete Zaitcev wrote:
> On Tue, 09 Feb 2010 04:38:21 -0500
> Jeff Garzik<jeff@garzik.org>  wrote:
>> On 02/09/2010 04:20 AM, Jeff Garzik wrote:
>
>>> Useful per-packet cld [the daemon] verbose output seems to have
>>> disappeared? Or did I miss a knob somewhere?
>>
>> cldcli no longers dumps per-packet debug info at maximum verbosity,
>> either.  Our built-in debug facilities have definitely regressed.
>
> I posted the patch for both server and client, which should fix it.
> Looks like we became confused about what the exact meaning for
> log.verbose is, since historically we had 2: one means
> "enable LOG_DEBUG" and the other "enable per-packet dumping"
> (which is really verbose in normal operation). So the patch
> splits the two, thus permitting cldcli to control verbosity
> precisely. And no more commented-out assignments.

Actually it should be as presented in "cld --help" and "cldcli --help": 
  an integer, whose increasing value indicates increasing verbosity. 
Higher values enable really verbose output, such as per-packet output.

So, the programs themselves have it right -- debug/verbose is an integer 
not a bool.  The internal libraries get that wrong sometimes, though.

Having separate knobs for 'debug' and 'verbose' will be more confusing 
than a single control, IMO.

	Jeff