From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Nf0Ui-0000e2-Vo for mharc-grub-devel@gnu.org; Tue, 09 Feb 2010 19:31:53 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nf0Ug-0000cd-Fp for grub-devel@gnu.org; Tue, 09 Feb 2010 19:31:50 -0500 Received: from [199.232.76.173] (port=46109 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nf0Uf-0000cA-Pz for grub-devel@gnu.org; Tue, 09 Feb 2010 19:31:49 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nf0Ue-00029E-W3 for grub-devel@gnu.org; Tue, 09 Feb 2010 19:31:49 -0500 Received: from mail-ew0-f228.google.com ([209.85.219.228]:57637) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nf0Ue-000294-KV for grub-devel@gnu.org; Tue, 09 Feb 2010 19:31:48 -0500 Received: by ewy28 with SMTP id 28so3782175ewy.8 for ; Tue, 09 Feb 2010 16:31:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=Klku9z8CCBpJCz/omLtNvSmixYeq1DybhGoiCgohCNI=; b=RjCOuUd78F26ptZU5nS6752lWeyO3oyFeWZQxieR1Hjhe4x27OamkEroz5GxA8o+G6 RdEIsGX29Fc7RnpkmXt+ygbrqBqTlokibzD+ffqqI4eI5b3OuAPJRIfWHzPvqCoGhGBr 95uikGwKfVEt9CEZRyVzSzz/46+ri7a8M4E44= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=YRL3WtnqQHmuOPcu/8tPdPxgmq6cScGdQvWe3zECvn8Nm8YRG65O76BsAEz4ROh4dN s690P2R8OX21ICEU2ThQm0xqCb0wTMAKAoR7tOuS8zlih3SCOm7A6njXI11OcTIk23hg p57eieo7KKiRB9rZoc6jnPKOvagnxUpkWFm44= Received: by 10.213.1.145 with SMTP id 17mr5081988ebf.46.1265761906426; Tue, 09 Feb 2010 16:31:46 -0800 (PST) Received: from debian.bg45.phnet (135.111.63.81.cust.bluewin.ch [81.63.111.135]) by mx.google.com with ESMTPS id 13sm462652ewy.9.2010.02.09.16.31.43 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 09 Feb 2010 16:31:44 -0800 (PST) Message-ID: <4B71FE67.20608@gmail.com> Date: Wed, 10 Feb 2010 01:31:35 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <87iqae3bd0.wl%jir@sekiba.com> In-Reply-To: <87iqae3bd0.wl%jir@sekiba.com> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigFD6B442108A97B801F271445" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] a new filessytem module for nilfs2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2010 00:31:50 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFD6B442108A97B801F271445 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jiro SEKIBA wrote: > Hi, > > This is a patch to support nilfs2 filesystem. > I would like you to review the patch. > > I've checked with revno 2153 and kvm(qemu) environment. > > Also the patch has already an ability to boot the kernel from > the nilfs partition, I have a following ToDo list to improve the module= =2E > > 1. revision check for future disk layout changes > 2. CRC check for superblock to ensure the partition is a nilfs2 partiti= on > 3. CRC check latest log block to ensure valid log=20 > 4. search the latest log in case unclean unmount happened > > nilfs2 stands for New Implementation of Log Filesystem version2. > nilfs2 has been merged into linux main line kernel since 2.6.30. > > Please give me any comments or advice. > > thank you very much in advance > =20 +pkglib_MODULES +=3D fshelp.mod fat.mod ufs1.mod ufs2.mod ext2.mod nilfs2.mod \ + ntfs.mod ntfscomp.mod minix.mod hfs.mod jfs.mod iso9660.mod xfs.mod \ For new modules we prefer to add pkglib_MODULES+=3D directly before the module itself +/* ext2.c - Second Extended filesystem */ +/* Leftover +#define DIV_ROUND_UP(n,d) (((n) + (d) - 1) / (d)) This can go into misc.h iterate_dir: + /* Search the file. */ + while (fpos < grub_le_to_cpu64 (diro->inode.i_size)) + { Another leftover I'm no nilfs2 expert but assuming that it works it's a good patch. Have you tested it on big-endian system? If no nd you have no access to such send me testing instructions, I have a powerpc machine (or one can use qemu). Nice job > -----------------------------------------------------------------------= - > > > =20 > -----------------------------------------------------------------------= - > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigFD6B442108A97B801F271445 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAktx/m8ACgkQNak7dOguQgn7XQD+P+jI4HHQYAZBiQPYd0ODpDdz ad7Dv4pXFdrY/QA5a9ABAL0/wPeFwPVz8QO/owy3oN421byZ2ZTvhEyN8kFWmh6g =bPCg -----END PGP SIGNATURE----- --------------enigFD6B442108A97B801F271445--