From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data Date: Wed, 10 Feb 2010 15:45:30 +0100 Message-ID: <4B72C68A.8020300@grandegger.com> References: <1264685141-26391-1-git-send-email-wg@grandegger.com> <1264685141-26391-2-git-send-email-wg@grandegger.com> <4B7285D5.9060008@grandegger.com> <20100210213203.48a9105e.sfr@canb.auug.org.au> <4B729043.9080303@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Grant Likely Cc: Stephen Rothwell , Ben Dooks , Devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wolfgang Grandegger List-Id: linux-i2c@vger.kernel.org Grant Likely wrote: > On Wed, Feb 10, 2010 at 3:53 AM, Wolfgang Grandegger wrote: >> Stephen Rothwell wrote: >>> Hi Wolfgang, >>> >>> On Wed, 10 Feb 2010 11:09:25 +0100 Wolfgang Grandegger wrote: >>>>> __devinitdata goes at the end, immediately before the '='. Ditto >>>>> throughout the file. >>>> This made a difference and revealed section mismatches. "const" seems to >>>> be incompatible with "__devinitdata". >>> Maybe try no "const" and "__devinitconst" (I am not sure if both will >>> work). >> Yes, that works, even together with "const". To avoid rolling out the >> whole patch series again, I can prepare a follow-up patch fixing this issue. > > Nah, just resend this one patch. Even if it break the following patches? Will resend v7 in a second. Wolfgang. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4B72C68A.8020300@grandegger.com> Date: Wed, 10 Feb 2010 15:45:30 +0100 From: Wolfgang Grandegger MIME-Version: 1.0 To: Grant Likely Subject: Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data References: <1264685141-26391-1-git-send-email-wg@grandegger.com> <1264685141-26391-2-git-send-email-wg@grandegger.com> <4B7285D5.9060008@grandegger.com> <20100210213203.48a9105e.sfr@canb.auug.org.au> <4B729043.9080303@grandegger.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Cc: Stephen Rothwell , Devicetree-discuss@lists.ozlabs.org, Linux-i2c@vger.kernel.org, Ben Dooks , Linuxppc-dev@lists.ozlabs.org, Wolfgang Grandegger List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Grant Likely wrote: > On Wed, Feb 10, 2010 at 3:53 AM, Wolfgang Grandegger wrote: >> Stephen Rothwell wrote: >>> Hi Wolfgang, >>> >>> On Wed, 10 Feb 2010 11:09:25 +0100 Wolfgang Grandegger wrote: >>>>> __devinitdata goes at the end, immediately before the '='. Ditto >>>>> throughout the file. >>>> This made a difference and revealed section mismatches. "const" seems to >>>> be incompatible with "__devinitdata". >>> Maybe try no "const" and "__devinitconst" (I am not sure if both will >>> work). >> Yes, that works, even together with "const". To avoid rolling out the >> whole patch series again, I can prepare a follow-up patch fixing this issue. > > Nah, just resend this one patch. Even if it break the following patches? Will resend v7 in a second. Wolfgang.