From: Mike Christie <michaelc@cs.wisc.edu>
To: Michael Reed <mdr@sgi.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
James Smart <James.Smart@Emulex.Com>,
James Bottomley <James.Bottomley@suse.de>
Subject: Re: [PATCH 1/1] mid-layer unblocks blocked sdev leaving queue stopped
Date: Wed, 10 Feb 2010 16:57:11 -0600 [thread overview]
Message-ID: <4B7339C7.10403@cs.wisc.edu> (raw)
In-Reply-To: <4B73322F.2000001@sgi.com>
On 02/10/2010 04:24 PM, Michael Reed wrote:
>> + /*
>> + * If device is blocked, leave state alone and let blocker
>> + * unblock when appropriate. Otherwise, set the device
>> + * running here so that slave configure may perform i/o.
>> + */
>> + if (sdev->sdev_state != SDEV_BLOCK) {
>> + ret = scsi_device_set_state(sdev, SDEV_RUNNING);
Do we need locking here? Is it possible that right after we check the
sdev_state for being blocked, it could be be set to blocked?
next prev parent reply other threads:[~2010-02-10 22:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 22:43 [PATCH 1/1] mid-layer unblocks blocked sdev leaving queue stopped Michael Reed
2010-02-10 22:24 ` Michael Reed
2010-02-10 22:57 ` Mike Christie [this message]
2010-02-16 21:48 ` Michael Reed
2010-02-24 20:17 ` Michael Reed
2010-03-09 16:14 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7339C7.10403@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@suse.de \
--cc=James.Smart@Emulex.Com \
--cc=linux-scsi@vger.kernel.org \
--cc=mdr@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.