From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH] [PVOPS] fix gntdev on PAE Date: Wed, 10 Feb 2010 15:12:20 -0800 Message-ID: <4B733D54.8010008@goop.org> References: <4B71DA53.1080404@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 02/10/2010 04:19 AM, Stefano Stabellini wrote: > On Tue, 9 Feb 2010, Jeremy Fitzhardinge wrote: > >> On 02/01/2010 07:46 AM, Stefano Stabellini wrote: >> >>> On Mon, 1 Feb 2010, Stefano Stabellini wrote: >>> >>> >>>> Hi all, >>>> this small patch fixes gntdev on Linux pvops kernels: >>>> gnttab_set_map_op and gnttab_set_unmap_op shouldn't take unsigned long >>>> as parameters for machine addresses because they are not big enough on >>>> PAE systems. >>>> This patch fixes the issue using phys_addr_t instead and enables >>>> XEN_GNTDEV compilation again. >>>> >>>> >>>> Signed-off-by: Stefano Stabellini >>>> >>>> >>>> >>> BTW gntdev is used by qemu to provide the console backend to pv guests. >>> >>> >> Is that recent? Console had been working before hadn't it? >> >> The gntdev problems I saw were more locking related than anything to do >> with PAE. Did you try testing with lock debugging enabled? >> >> > Yes, I don't have any problem with locking in gntdev on my testbox. > OK, I'll give it another go. J