From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NfbDH-0001T4-5C for mharc-grub-devel@gnu.org; Thu, 11 Feb 2010 10:44:19 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NfbDG-0001SR-0Q for grub-devel@gnu.org; Thu, 11 Feb 2010 10:44:18 -0500 Received: from [199.232.76.173] (port=44452 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NfbDF-0001S5-7Z for grub-devel@gnu.org; Thu, 11 Feb 2010 10:44:17 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NfbDE-0004rS-1a for grub-devel@gnu.org; Thu, 11 Feb 2010 10:44:16 -0500 Received: from mail-bw0-f219.google.com ([209.85.218.219]:59912) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NfbDD-0004rM-GP for grub-devel@gnu.org; Thu, 11 Feb 2010 10:44:15 -0500 Received: by bwz19 with SMTP id 19so422539bwz.8 for ; Thu, 11 Feb 2010 07:44:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=/tZ8T19g/YlkKU0UVGldlNRKjF1CDR/CvfGPDPbc668=; b=XvkKXzggiuYZI+Bla7P08X89G/n2++OLexAf/Ne0hvrnpX1kPRfOkPw6eVuZRN7SCa kVi8bxXcAI1sibl3BSJz9A49XztZRu8xVmqgGZE468wQCnvUfczXfePR7eHeITc+JhkR hF+b4q5JcpF1NSjYhBkSnShnmPMN0GjnCUo7g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=WcRlT6QGVwrLQFry7sYYXU8mVlpgBrwcgjJMKF1bqHMzoeJDcR4xfQsFQbXG3W4a7R pFHkZesx81wM8FC9MmNopNJp7dy1+OxJXYiNSSRpuluLujppcds0mS7fMQyAqh72gQfI QwWBt1XmiVKGZejCJcCK2gMpaZWlHgUoI+xLE= Received: by 10.204.6.201 with SMTP id a9mr15413bka.87.1265903054279; Thu, 11 Feb 2010 07:44:14 -0800 (PST) Received: from debian.bg45.phnet (gprs39.swisscom-mobile.ch [193.247.250.39]) by mx.google.com with ESMTPS id 16sm1122339bwz.15.2010.02.11.07.44.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 11 Feb 2010 07:44:12 -0800 (PST) Message-ID: <4B7425C0.3060309@gmail.com> Date: Thu, 11 Feb 2010 16:44:00 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: In-Reply-To: X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig2B2E2F470ED9947B5500EDF6" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [patch] GRUB possible patches X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2010 15:44:18 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2B2E2F470ED9947B5500EDF6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable George Buranov wrote: > Hello eveybody. > > I am currently start investigation (and fixing the things that don't > work for me =3D)) > > So, I got two for today, one is fix, and one is morelike a question, I > am more than sure it's my mistake. > > What's the correct way of applying patches to grub2? Am I correct that > all I need is to post the patch to this mailing list and than some > guys are applying them?:) > > 1) IMHO that's clearly a bug. It is. Can you write a ChangeLog entry? > Actually, I am not sure how did it work before =3D) It's a rarely used branch of code. > > =3D=3D=3D modified file 'disk/efi/efidisk.c' > --- disk/efi/efidisk.c 2010-01-20 08:12:47 +0000 > +++ disk/efi/efidisk.c 2010-02-11 10:58:49 +0000 > @@ -825,7 +825,7 @@ > if (! disk) > return 1; > > - if (disk->id =3D=3D GRUB_DISK_DEVICE_EFIDISK_ID) > + if (disk->dev && disk->dev->id =3D=3D GRUB_DISK_DEVICE_EFIDIS= K_ID) > { > struct grub_efidisk_data *d; > > 2) That's more interesting. I nocticed that when I try to browse CD > (ISO 9660 format) all files are ended with ";1". This basically > crashed loading everything (including grub.cfg file). I fixed this by > this stupid hack, but maybe somebody knows where is the clue? > ;1 is so called version. Basically all terminating ; have to be stripped but only if filename doesn't come from rockridge or joliet. Apparently nobody uses grub2 on non-rockridge, non-joliet iso. While this bug should be fixed using grub from plain iso isn't supported due to filename length limitation. > http://picasaweb.google.com/lh/photo/psaYCXsX_M77pdG4_qeFGw?feat=3Ddire= ctlink > > =3D=3D=3D modified file 'fs/iso9660.c' > --- fs/iso9660.c 2010-01-27 03:11:20 +0000 > +++ fs/iso9660.c 2010-02-11 11:11:36 +0000 > @@ -638,6 +638,9 @@ > if (filename_alloc) > grub_free (oldname); > > + int hookedFile =3D grub_strlen (filename); > + filename[hookedFile - 2] =3D '\0'; > + > filename_alloc =3D 1; > } > > > Regards, > Georgy > -----------------------------------------------------------------------= - > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig2B2E2F470ED9947B5500EDF6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAkt0JcYACgkQNak7dOguQgklsQD9HnKaJJDi8dK/JZOPdEoh5Q26 RJwGc5Lp+NrB/BieLlYBAJ601JWdtqx9SeFOSxt9IHobelhpv9MQuhvkeQZQ6aby =v3Gk -----END PGP SIGNATURE----- --------------enig2B2E2F470ED9947B5500EDF6--