From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NfbdJ-0005vn-4r for mharc-grub-devel@gnu.org; Thu, 11 Feb 2010 11:11:13 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NfbdI-0005vE-4D for grub-devel@gnu.org; Thu, 11 Feb 2010 11:11:12 -0500 Received: from [199.232.76.173] (port=55640 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NfbdH-0005ui-KR for grub-devel@gnu.org; Thu, 11 Feb 2010 11:11:11 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NfbdG-0008ML-Ld for grub-devel@gnu.org; Thu, 11 Feb 2010 11:11:11 -0500 Received: from mail-bw0-f219.google.com ([209.85.218.219]:50930) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NfbdF-0008Lv-Rw for grub-devel@gnu.org; Thu, 11 Feb 2010 11:11:10 -0500 Received: by bwz19 with SMTP id 19so453386bwz.8 for ; Thu, 11 Feb 2010 08:11:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=8wZF1W9r6ZX6+XnUL8kiWjqPKUf+Ad4hr7nJSLEgMbU=; b=eISJaXlp9wbPMp5oe/4aEvx1FacdvDKmUxqrhenR/ye6KSfjWwZlCcCEiACNE9Jr/X J7aOCnrXGmcePBGT8fFhdIkwJ4117gS0dAaUFvE02SJq6YAvAbgFufkhAWAxE62WOzWg Lu4FWdIDtTBVV0FOrJI++qg4OLst/qqpCj4GM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=IkKZWWtunKSdR9M6L9NK9mS5cd5Q7afjCZIgKEjLdtlUI3hVWzybotzpWyk2CVmqiS +0fRh6KOdlPSto5V8GJNPzc/QgTCTyEhgmd6VaoBMFXtx0KjPpq6ZO40Ehh9k6EYL3I9 9JfM1RtvMQ5KmDXBn4SGNhVl1apNdoAOI0fDs= Received: by 10.204.0.84 with SMTP id 20mr55235bka.5.1265904668940; Thu, 11 Feb 2010 08:11:08 -0800 (PST) Received: from debian.bg45.phnet (gprs39.swisscom-mobile.ch [193.247.250.39]) by mx.google.com with ESMTPS id 16sm1135607bwz.7.2010.02.11.08.11.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 11 Feb 2010 08:11:07 -0800 (PST) Message-ID: <4B742C16.2020304@gmail.com> Date: Thu, 11 Feb 2010 17:11:02 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <4B736F82.7010005@gmail.com> In-Reply-To: X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigEEC7E7F4312169B6F111F0DD" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [RFC] Framebuffer rotation patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2010 16:11:12 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEEC7E7F4312169B6F111F0DD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Michal Suchanek wrote: > On 11 February 2010 11:19, Michal Suchanek wrote:= > =20 >> 2010/2/11 Vladimir '=CF=86-coder/phcoder' Serbinenko : >> =20 >>> Michal Suchanek wrote: >>> =20 >>>> Hello >>>> >>>> Sending a preliminary framebuffer rotation patch. >>>> >>>> You can use videotest to see 4 tiles rotated from the same bitmap da= ta. >>>> >>>> >>>> =20 >>> +char leaf_data[] =3D { 0x00, 0x0f, 0xe0, 0x00, >>> + 0x00, 0x7f, 0xfc, 0x00, >>> + 0x01, 0xff, 0xff, 0x00, >>> + 0x03, 0xff, 0xff, 0x80, >>> This is a blob. Could it be generated automatically at build time? >>> =20 >> How less of a blob it would be if it was included as a bitmap? >> >> This is just a shape used for the video tests. >> >> There are some X tools for working with bitmaps/pixmaps which could >> generate this from a viewable file but they are usually not available >> on Windows and other non-X platforms AFAIK. >> >> =20 >>> + >>> + sans =3D grub_font_get ("Helvetica Bold 14"); >>> Please use free font rather than Helvetica >>> =20 >> I am pretty sure I did not choose the fonts, they must have been there= >> before I started with modifications to the tests. >> >> =20 >>> Could you split addition of videotests from the rest of the patch? >>> - unsigned int x; >>> - unsigned int y; >>> - unsigned int width; >>> - unsigned int height; >>> + int x; >>> + int y; >>> + int width; >>> + int height; >>> Why do you need negative values? >>> =20 >> I don't need the negative values everywhere but this change was to >> align the typing so that casts are not required. >> >> =20 >>> +/* Supported operations are simple and easy to understand. >>> + * MIRROR | swap image across (around) the vertical axis >>> + * FLIP - swap image across the horizontal axis - upside down >>> + * SWAP / swap image across the x=3Dy axis - swap the x and y co= ordinates >>> It's just a D_8 group. Could you add a comment to functions what they= do >>> in group theoretical sense? It would make the code easier to follow a= nd >>> =20 >> Obviously it is a group, any set of transforms closed on composition i= s. >> >> And according to Wikipedia it's actually called D4. >> >> =20 >>> compute transformations for mathematicians. Perhaps another >>> representation of D_8 would result in more efficient code? >>> =20 >> If you have clearer explanation or more efficient code please share. >> >> =20 > > Let me elaborate a bit more on this one. > > The provided explanation should make it possible for anybody who > understands plain English to also understand the operations used and > how they interact should they know group theory in English, any other > language, or not at all. > =20 Perhaps one could add an example of how it moves vertices of a square? E.g for vertical flip: 1---2 2----1 | | --> | | 4---3 3----4 > I guess mentioning the English mathematical terms where applicable and > where I can figure them out should not that much of a problem, as well > as checking that the transform functions are sufficiently described. > > =20 Feel free to ask any questions. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigEEC7E7F4312169B6F111F0DD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAkt0LBYACgkQNak7dOguQgkKzgEAvr4n3auZXvaV6kS/TFz3PFfT f8wvEZRGhq+bWo2p7jgBAMMfmcbHXbK0/0t3eut+DtD9Cu7neqEBXhiROD8kOHw/ =3apn -----END PGP SIGNATURE----- --------------enigEEC7E7F4312169B6F111F0DD--