From: Peter Staubach <staubach@redhat.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: iisaman@citi.umich.edu, linux-nfs@vger.kernel.org
Subject: Re: [PATCH pynfs] Allow server to reject maximum commit offsets
Date: Thu, 11 Feb 2010 16:32:33 -0500 [thread overview]
Message-ID: <4B747771.40902@redhat.com> (raw)
In-Reply-To: <20100211203857.GF3801@fieldses.org>
J. Bruce Fields wrote:
> On Tue, Feb 09, 2010 at 05:50:18PM -0500, J. Bruce Fields wrote:
>> The tests are primarily meant to test protocol conformance. So they
>> shouldn't be reporting failures on conforming behavior.
>>
>> Perhaps it would also be interesting to run the tests in a mode which
>> probes and summarizes server characteristics (maximum supported offset,
>> supported features, etc.), but that's a job for another day.
>
> Hm, actually another alternative would be just to keep these tests, but
> to *always* allow them to succeed. Or to fail only if the server
> returns an error that really is totally wrong.
>
> Even if we don't much care about the results, sending operations with
> extreme values for the arguments may still help make sure server's don't
> skimp on the range-checking and crash in some lower-level code.
>
This sounds reasonable to me.
ps
next prev parent reply other threads:[~2010-02-11 21:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 20:12 [PATCH pynfs] Allow server to reject maximum commit offsets J. Bruce Fields
2010-02-09 20:13 ` J. Bruce Fields
2010-02-09 22:28 ` Peter Staubach
2010-02-09 22:42 ` J. Bruce Fields
2010-02-09 22:45 ` Peter Staubach
2010-02-09 22:50 ` J. Bruce Fields
2010-02-11 20:38 ` J. Bruce Fields
2010-02-11 21:32 ` Peter Staubach [this message]
2010-02-09 22:44 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B747771.40902@redhat.com \
--to=staubach@redhat.com \
--cc=bfields@fieldses.org \
--cc=iisaman@citi.umich.edu \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.