All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
	Mocean Laboratories <info@mocean-labs.com>,
	Juergen Beisert <j.beisert@pengutronix.de>,
	Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: [PATCH -mmotm] timberdale: fix mfd build
Date: Thu, 11 Feb 2010 15:30:14 -0800	[thread overview]
Message-ID: <4B749306.4050509@oracle.com> (raw)
In-Reply-To: <20100211143646.f357c9ee.akpm@linux-foundation.org>

> This?

Nope, still has the same error.
Use this one instead.  It builds now.

---
From: Randy Dunlap <randy.dunlap@oracle.com>

Fix mfd/timberdale build error -- add depends GPIOLIB.

include/linux/spi/max7301.h:14: error: field 'chip' has incomplete type
build-r7353.out:make[3]: *** [drivers/mfd/timberdale.o] Error 1

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/mfd/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- mmotm-2010-0210-1617.orig/drivers/mfd/Kconfig
+++ mmotm-2010-0210-1617/drivers/mfd/Kconfig
@@ -382,7 +382,7 @@ config AB4500_CORE
 config MFD_TIMBERDALE
 	tristate "Support for the Timberdale FPGA"
 	select MFD_CORE
-	depends on PCI
+	depends on PCI && GPIOLIB
 	---help---
 	This is the core driver for the timberdale FPGA. This device is a
 	multifunction device which exposes numerous platform devices.

  reply	other threads:[~2010-02-11 23:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-11  0:17 mmotm 2010-02-10-16-17 uploaded akpm
2010-02-11  2:43 ` mmotm 2010-02-10-16-17 uploaded (timberdale) Randy Dunlap
2010-02-11 22:01   ` Andrew Morton
2010-02-11 22:18     ` Randy Dunlap
2010-02-11 22:36       ` Andrew Morton
2010-02-11 23:30         ` Randy Dunlap [this message]
2010-02-11  5:11 ` mmotm 2010-02-10 - lockdep whinge in ACPI code Valdis.Kletnieks
2010-02-11  5:26   ` Andrew Morton
2010-02-11 15:01     ` Greg KH
2010-02-12  2:11     ` Dave Young
2010-02-12  2:11       ` Dave Young
2010-02-12  2:44 ` mmotm 2010-02-10 - BUG at fs/dcache.c:677! Valdis.Kletnieks
2010-02-12  3:14   ` Andrew Morton
2010-02-12  4:51     ` Jun'ichi Nomura
2010-02-12  5:01       ` Al Viro
2010-02-12  5:07         ` Al Viro
2010-02-12  5:30       ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B749306.4050509@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=g.liakhovetski@pengutronix.de \
    --cc=info@mocean-labs.com \
    --cc=j.beisert@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.