From: Jeff Mahoney <jeffm@suse.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: Re: [PATCH] delayacct: align to 8 byte boundary on 64-bit systems
Date: Fri, 12 Feb 2010 14:34:13 -0500 [thread overview]
Message-ID: <4B75AD35.3080207@suse.com> (raw)
In-Reply-To: <20100212112912.be58b670.akpm@linux-foundation.org>
On 02/12/2010 02:29 PM, Andrew Morton wrote:
> On Fri, 12 Feb 2010 14:20:23 -0500
> Jeff Mahoney <jeffm@suse.com> wrote:
>
>>> Seems safe enough. We'd be safer still if we didn't do this on 64-bit
>>> architectures which don't need it. ie: x86_64. But if we do that we
>>> add a risk that people will develop shoddy code which works on x86_64
>>> and doesn't work on ia64.
>>
>> Is there a way to do that without needlessly complicating things? I
>> didn't see any existing infrastructure to do that.
>
> ifdefs? I don't think it's worth doing, really. Probably anyone who
> wrote an application for this copied the getdelays.c code anyway.
Yeah I didn't want to get into #if defined(LIST OF ARCHES) for this. I
was hoping for a way to get the alignment rules for the arch. In the
absence of that, this is good enough. You're probably right about people
just lifting the getdelays.c code.
-Jeff
--
Jeff Mahoney
SUSE Labs
next prev parent reply other threads:[~2010-02-12 19:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 16:48 [PATCH] delayacct: align to 8 byte boundary on 64-bit systems Jeff Mahoney
2010-02-12 18:19 ` Andrew Morton
2010-02-12 19:20 ` Jeff Mahoney
2010-02-12 19:29 ` Andrew Morton
2010-02-12 19:34 ` Jeff Mahoney [this message]
2010-02-13 2:14 ` Balbir Singh
2010-02-17 21:47 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B75AD35.3080207@suse.com \
--to=jeffm@suse.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.