All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm <kvm@vger.kernel.org>
Subject: [PATCH] KVM: VMX: Update instruction length on intercepted BP
Date: Sat, 13 Feb 2010 10:31:12 +0100	[thread overview]
Message-ID: <4B767160.4070609@web.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

From: Jan Kiszka <jan.kiszka@siemens.com>

We intercept #BP while in guest debugging mode. As VM exists due to
intercepted exceptions do not necessarily come with valid
idt_vectoring, we have to update event_exit_inst_len explicitly in such
cases. At least in the absence of migration, this ensures that
re-injections of #BP will find and use the correct instruction length.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

Please consider for stable, this fixes guest debugging scenarios.

 arch/x86/kvm/vmx.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index f82b072..e9f64e8 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -2775,6 +2775,8 @@ static int handle_rmode_exception(struct kvm_vcpu *vcpu,
 		kvm_queue_exception(vcpu, vec);
 		return 1;
 	case BP_VECTOR:
+		to_vmx(vcpu)->vcpu.arch.event_exit_inst_len =
+			vmcs_read32(VM_EXIT_INSTRUCTION_LEN);
 		if (vcpu->guest_debug & KVM_GUESTDBG_USE_SW_BP)
 			return 0;
 		/* fall through */
@@ -2897,6 +2899,8 @@ static int handle_exception(struct kvm_vcpu *vcpu)
 		kvm_run->debug.arch.dr7 = vmcs_readl(GUEST_DR7);
 		/* fall through */
 	case BP_VECTOR:
+		vmx->vcpu.arch.event_exit_inst_len =
+			vmcs_read32(VM_EXIT_INSTRUCTION_LEN);
 		kvm_run->exit_reason = KVM_EXIT_DEBUG;
 		kvm_run->debug.arch.pc = vmcs_readl(GUEST_CS_BASE) + rip;
 		kvm_run->debug.arch.exception = ex_no;


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

             reply	other threads:[~2010-02-13  9:31 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-13  9:31 Jan Kiszka [this message]
2010-02-14  7:53 ` [PATCH] KVM: VMX: Update instruction length on intercepted BP Gleb Natapov
2010-02-14 10:26   ` Jan Kiszka
2010-02-14 10:34     ` Gleb Natapov
2010-02-14 10:47       ` Jan Kiszka
2010-02-14 11:15         ` Gleb Natapov
2010-02-14 11:39           ` Jan Kiszka
2010-02-14 14:16             ` Avi Kivity
2010-02-14 16:38               ` Jan Kiszka
2010-02-14 16:44                 ` Avi Kivity
2010-02-14 17:06                   ` Jan Kiszka
2010-02-15  6:48                     ` Avi Kivity
2010-02-14 14:45             ` Gleb Natapov
2010-02-14 16:37               ` Jan Kiszka
2010-02-14 16:53                 ` Gleb Natapov
2010-02-14 17:06                   ` Jan Kiszka
2010-02-14 17:26                     ` Gleb Natapov
2010-02-14 17:49                       ` Jan Kiszka
2010-02-15 13:20                         ` Jan Kiszka
2010-02-15 13:30                           ` Gleb Natapov
2010-02-15 14:25                             ` Jan Kiszka
2010-02-17 11:11                             ` Avi Kivity
2010-02-17 11:13                               ` Gleb Natapov
2010-02-17 11:24                                 ` Jan Kiszka
2010-02-17 12:39                                   ` Gleb Natapov
2010-02-17 10:55                           ` Gleb Natapov
2010-02-17 11:32                             ` Jan Kiszka
2010-02-17 13:03                               ` Gleb Natapov
2010-02-17 15:13                                 ` Jan Kiszka
2010-02-17 16:11                                   ` Gleb Natapov
2010-02-16 11:20                         ` Gleb Natapov
2010-02-16 11:25                           ` Gleb Natapov
2010-02-14 12:27       ` Avi Kivity
2010-02-14 12:39         ` Jan Kiszka
2010-02-14 12:43           ` Gleb Natapov
2010-02-14 12:47             ` Avi Kivity
2010-02-14 12:53               ` Gleb Natapov
2010-02-14 13:23               ` Jan Kiszka
2010-02-14 13:29                 ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B767160.4070609@web.de \
    --to=jan.kiszka@web.de \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.