From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: x86: Add instruction length to VCPU event state
Date: Sat, 13 Feb 2010 12:21:47 +0200 [thread overview]
Message-ID: <4B767D3B.10306@redhat.com> (raw)
In-Reply-To: <4B76762C.10107@web.de>
On 02/13/2010 11:51 AM, Jan Kiszka wrote:
> From: Jan Kiszka<jan.kiszka@siemens.com>
>
> VMX requires a properly set instruction length VM entry field when
> trying to inject soft exception and interrupts. We have to preserve this
> state across VM save/restore to avoid breaking the re-injection of such
> events on Intel. So add it to the new VCPU event state.
>
>
Can't we fake it? set instruction length to 1 and rewind rip by 1.
The only case where I think this can fail is if we have a fault during
the soft exception injection.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-02-13 10:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 9:51 [PATCH] KVM: x86: Add instruction length to VCPU event state Jan Kiszka
2010-02-13 10:21 ` Avi Kivity [this message]
2010-02-13 10:55 ` Jan Kiszka
2010-02-13 15:26 ` Gleb Natapov
2010-02-13 17:49 ` Jan Kiszka
2010-02-13 18:22 ` Gleb Natapov
2010-02-13 18:41 ` Jan Kiszka
2010-02-13 19:06 ` Gleb Natapov
2010-02-13 19:20 ` Jan Kiszka
2010-02-13 19:25 ` Gleb Natapov
2010-02-14 10:19 ` Jan Kiszka
2010-02-14 13:44 ` Paolo Bonzini
2010-02-14 14:38 ` Gleb Natapov
2010-02-14 15:10 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B767D3B.10306@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.