From: Markus Elfring <Markus.Elfring@web.de>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix signal handler
Date: Sat, 13 Feb 2010 14:30:45 +0100 [thread overview]
Message-ID: <4B76A985.9070809@web.de> (raw)
In-Reply-To: <20100210173348.GA5091@coredump.intra.peff.net>
>
> Why does this need to become extern?
How do you think about to stress the detail that the function
"log_show_early" is called by the function "limit_list" from an other
translation unit.
>
> Overall, this change looks sane to me.
How are the chances to get the update suggestion into the public Git
repository?
> You still haven't provided any evidence that this is a problem in practice,
> but these changes are not particularly cumbersome, so it is probably better
> to be on the safe side.
>
It is a matter of safety if all implementation details of the source
code conform to well-known programming standards.
Regards,
Markus
next prev parent reply other threads:[~2010-02-13 13:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 16:14 Fix signal handler Markus Elfring
2010-02-02 20:58 ` Jeff King
2010-02-02 21:44 ` Markus Elfring
2010-02-02 22:32 ` Jeff King
2010-02-03 10:20 ` Markus Elfring
2010-02-03 10:29 ` Jeff King
2010-02-03 11:55 ` Markus Elfring
2010-02-03 13:12 ` Thomas Rast
2010-02-03 15:46 ` Markus Elfring
2010-02-03 15:52 ` Shawn O. Pearce
2010-02-03 15:53 ` Andreas Ericsson
2010-02-03 16:24 ` Markus Elfring
2010-02-04 7:23 ` Andreas Ericsson
2010-02-03 15:17 ` Jeff King
2010-02-03 16:04 ` Markus Elfring
2010-02-03 16:26 ` Bill Lear
2010-02-09 18:01 ` Markus Elfring
2010-02-09 23:49 ` Daniel Barkalow
2010-02-10 17:08 ` [PATCH] " Markus Elfring
2010-02-10 17:14 ` Shawn O. Pearce
2010-02-10 17:35 ` Jeff King
2010-02-10 17:33 ` Jeff King
2010-02-13 13:30 ` Markus Elfring [this message]
2010-02-14 6:47 ` Jeff King
2010-02-14 10:19 ` Junio C Hamano
2010-02-18 16:31 ` Markus Elfring
2010-02-18 20:06 ` Junio C Hamano
2010-02-19 11:05 ` Markus Elfring
2010-02-22 12:10 ` [PATCH] Fix a " Markus Elfring
2010-02-22 18:31 ` Junio C Hamano
2010-02-23 8:55 ` Markus Elfring
2010-02-23 9:10 ` Markus Elfring
2010-02-23 21:48 ` Junio C Hamano
2010-02-24 10:38 ` Markus Elfring
2010-02-24 10:51 ` Andreas Ericsson
2010-02-24 11:08 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B76A985.9070809@web.de \
--to=markus.elfring@web.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.