From: Andreas Petlund <apetlund@simula.no>
To: William Allen Simpson <william.allen.simpson@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>,
"Eric Dumazet" <eric.dumazet@gmail.com>,
"Arnd Hannemann" <hannemann@nets.rwth-aachen.de>,
LKML <linux-kernel@vger.kernel.org>,
shemminger@vyatta.com, "David Miller" <davem@davemloft.net>,
damian@tvk.rwth-aachen.de
Subject: Re: [net-next PATCH v3 3/3] net: TCP thin dupack
Date: Sat, 13 Feb 2010 16:50:19 +0100 [thread overview]
Message-ID: <4B76CA3B.4010206@simula.no> (raw)
In-Reply-To: <4B753943.2080800@gmail.com>
On 12. feb. 2010 12:19, William Allen Simpson wrote:
> Last year, I'm pretty sure I was on record as thinking this is *not* a
> good idea. But at least it now requires a sysctl to turn on, and
> should default to off.
>
> Also that naming was a bit dicey. Now the names are more descriptive,
> but the "force" is a bit overkill.
>
> How about:
> NET_TCP_FORCE_THIN_LINEAR_DUPACK -> NET_TCP_THIN_LINEAR_DUPACK
> tcp_force_thin_dupack -> tcp_thin_linear_dupack
> sysctl_tcp_force_thin_dupack -> sysctl_tcp_thin_linear_dupack
You uncovered a copy/paste/edit-typo there. The term "linear" had snuck
in even though it does not make sense for this patch. I think that
NET_TCP_THIN_DUPACK, tcp_thin_dupack and sysctl_tcp_thin_dupack will
be better.
Best regards,
Andreas
next prev parent reply other threads:[~2010-02-13 15:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 12:07 [net-next PATCH v3 3/3] net: TCP thin dupack Andreas Petlund
2010-02-12 11:19 ` William Allen Simpson
2010-02-12 11:43 ` Ilpo Järvinen
2010-02-13 15:50 ` Andreas Petlund [this message]
2010-02-13 2:13 ` Eric W. Biederman
2010-02-13 15:50 ` Andreas Petlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B76CA3B.4010206@simula.no \
--to=apetlund@simula.no \
--cc=damian@tvk.rwth-aachen.de \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hannemann@nets.rwth-aachen.de \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=william.allen.simpson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.