From: Jeff Garzik <jgarzik@pobox.com>
To: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Cc: Frans Pop <elendil@planet.nl>,
knan-lkml@anduin.net, bzolnier@gmail.com,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
vamos@i4.informatik.uni-erlangen.de, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] non-existant config in kernel source (CONFIG_AHCI)
Date: Sat, 13 Feb 2010 17:49:17 -0500 [thread overview]
Message-ID: <4B772C6D.5000600@pobox.com> (raw)
In-Reply-To: <20100205152635.GC7299@faui49.informatik.uni-erlangen.de>
On 02/05/2010 10:26 AM, Christoph Egger wrote:
> On Fri, Feb 05, 2010 at 02:57:00PM +0100, Frans Pop wrote:
>> Christoph Egger wrote:
>>> --- a/drivers/ata/pata_marvell.c
>>> +++ b/drivers/ata/pata_marvell.c
>>> @@ -147,7 +147,7 @@ static int marvell_init_one (struct pci_dev *pdev,
>>> if (pdev->device == 0x6101)
>>> ppi[1] =&ata_dummy_port_info;
>>>
>>> -#if defined(CONFIG_AHCI) || defined(CONFIG_AHCI_MODULE)
>>> +#if defined(CONFIG_SATA_AHCI) || defined(SATA_CONFIG_AHCI_MODULE)
>>
>> Shouldn't the last be CONFIG_SATA_AHCI_MODULE ?
>
> Right my fault. Updated patch below
>
> -----
>> From 60136f94d9c97f9a788738e30731e25bd794322b Mon Sep 17 00:00:00 2001
> From: Christoph Egger<siccegge@stud.informatik.uni-erlangen.de>
> Date: Fri, 5 Feb 2010 13:26:33 +0100
> Subject: [PATCH] CONFIG_AHCI is really CONFIG_SATA_AHCI
>
> The marvell driver comtains a fallback to ahci for the sata ports
> which is incorrectly checked as CONFIG_AHCI while the only AHCI config
> item is actually called SATA_AHCI (which also sounds sensible
> considering it's a fallback for the sata ports).
>
> Signed-off-by: Christoph Egger<siccegge@stud.informatik.uni-erlangen.de>
> ---
> drivers/ata/pata_marvell.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
applied
next prev parent reply other threads:[~2010-02-13 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 13:29 [PATCH] non-existant config in kernel source (CONFIG_AHCI) Christoph Egger
2010-02-05 13:57 ` Frans Pop
2010-02-05 15:26 ` Christoph Egger
2010-02-13 22:49 ` Jeff Garzik [this message]
2010-02-05 14:08 ` Sergei Shtylyov
2010-02-05 17:32 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B772C6D.5000600@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=elendil@planet.nl \
--cc=knan-lkml@anduin.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siccegge@stud.informatik.uni-erlangen.de \
--cc=vamos@i4.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.