All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Jacob Meuser <jakemsr@openbsd.org>, qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] Give sdl-config higher priority than pkg-config
Date: Sun, 14 Feb 2010 13:04:31 +0100	[thread overview]
Message-ID: <4B77E6CF.7000901@redhat.com> (raw)
In-Reply-To: <f43fc5581002132323j734da576ubb58151dc9dd5840@mail.gmail.com>

On 02/14/2010 08:23 AM, Blue Swirl wrote:
> On OpenBSD, pkg-config sdl --cflags forgets to add -I/usr/local/include
> which is needed for iconv.h (included from SDL.h). This makes SDL
> detection fail.
>
> Try sdl-config first, only if it fails try pkg-config.

This breaks cross-compilation.  I'm CCing the OpenBSD package maintainer 
so that he can fix it.

Upstream SDL has

     --cflags)
       echo -I@includedir@/SDL @SDL_CFLAGS@
       ;;

in sdl-config.in and

Cflags: -I${includedir}/SDL @SDL_CFLAGS@

in sdl.pc.in, while OpenBSD has different values, so he modified 
sdl-config apparently but not sdl.pc.in.

Paolo

  reply	other threads:[~2010-02-14 12:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-14  7:23 [Qemu-devel] [PATCH] Give sdl-config higher priority than pkg-config Blue Swirl
2010-02-14 12:04 ` Paolo Bonzini [this message]
2010-02-14 14:14   ` [Qemu-devel] " Blue Swirl
2010-02-14 14:47     ` Paolo Bonzini
2010-02-14 15:19   ` Jacob Meuser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B77E6CF.7000901@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=jakemsr@openbsd.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.