From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ngqi4-0008B9-M4
	for qemu-devel@nongnu.org; Sun, 14 Feb 2010 21:29:16 -0500
Received: from [199.232.76.173] (port=39388 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ngqi4-0008Au-9O
	for qemu-devel@nongnu.org; Sun, 14 Feb 2010 21:29:16 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <techie@whiterocker.com>) id 1Ngqi3-0002aV-1k
	for qemu-devel@nongnu.org; Sun, 14 Feb 2010 21:29:16 -0500
Received: from mx6-3.i-mecca.net ([65.39.179.42]:43668)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <techie@whiterocker.com>) id 1Ngqi2-0002aP-OB
	for qemu-devel@nongnu.org; Sun, 14 Feb 2010 21:29:14 -0500
Received: from ns6.i-mecca.net (ns6 [127.0.0.1])
	by ns6.i-mecca.net (Postfix) with ESMTP id E9B557BD428
	for <qemu-devel@nongnu.org>; Sun, 14 Feb 2010 20:53:08 -0500 (EST)
Received: from kilgour.homelinux.com (unknown [97.107.180.199])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by ns6.i-mecca.net (Postfix) with ESMTPSA id 9A82D7BD428
	for <qemu-devel@nongnu.org>; Sun, 14 Feb 2010 20:53:08 -0500 (EST)
Message-ID: <4B78A904.9020700@whiterocker.com>
Date: Sun, 14 Feb 2010 17:53:08 -0800
From: Chris Kilgour <techie@whiterocker.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] [PATCH] pcnet APROMWE bit location
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

I don't subscribe to the list, so please excuse any breach of etiquette. 

According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.

Signed-off-by: Christopher Kilgour <techie <at> whiterocker.com>
---

diff --git a/hw/pcnet.c b/hw/pcnet.c
index 44b5b31..f889898 100644
--- a/hw/pcnet.c
+++ b/hw/pcnet.c
@@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque,
uint32_t addr
     printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
 #endif
     /* Check APROMWE bit to enable write access */
-    if (pcnet_bcr_readw(s,2) & 0x80)
+    if (pcnet_bcr_readw(s,2) & 0x100)
         s->prom[addr & 15] = val;
 }