Re: [PATCH] drm/radeon/kms: simplify picking power state

[Dana Goyette <DGoyette@calpoly.edu>]

On 02/14/2010 07:43 PM, Alex Deucher wrote:
> On Fri, Feb 12, 2010 at 10:38 AM, Dana Goyette<dgoyette@calpoly.edu>  wrote:
>    
>> On 02/11/2010 02:00 PM, Rafał Miłecki wrote:
>>      
>>> W dniu 11 lutego 2010 22:50 użytkownik Rafał Miłecki<zajec5@gmail.com>
>>>   napisał:
>>>        
>>>> ---
>>>>   drivers/gpu/drm/radeon/radeon_pm.c |   57
>>>> +++++++++++------------------------
>>>>   1 files changed, 18 insertions(+), 39 deletions(-)
>>>>          
>>> Dave you can add
>>> Signed-off-by: Rafał Miłecki<zajec5@gmail.com>
>>> of course, if you wish. Forgot that.
>>>
>>>        
>> Hmm, something to watch out for: what about cards that offer more than one
>> battery state?  Take my RV635 (Mobility HD3650), for example -- my card has
>> two battery states with different frequencies.
>>      
> They are for different things.  The dmesg output doesn't print out the
> full power state info.  Most likely one is for video playback that has
> slightly different performance or bandwidth requirements compared to
> the regular battery state.
>
> Alex
>    
On that note, how do you define which is the "regular" battery state?  
Right now, the PM code seems to miss the lowest-speed state, and thus 
doesn't save as much power as it ideally would.

------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
--