All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4 v4] arm: add support for the suen3 board from keymile
Date: Mon, 15 Feb 2010 09:08:25 +0100	[thread overview]
Message-ID: <4B7900F9.3030600@denx.de> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D1860FC8B2E@SC-VEXCH4.marvell.com>

Hello Prafulla,

Prafulla Wadaskar wrote:
>> -----Original Message-----
>> From: Heiko Schocher [mailto:hs at denx.de] 
>> Sent: Friday, February 12, 2010 1:36 PM
>> To: U-Boot user list
>> Cc: Wolfgang Denk; Prafulla Wadaskar; Scott Wood; Stefan Roese
>> Subject: [PATCH 2/4 v4] arm: add support for the suen3 board 
>> from keymile
>>
>> This patch adds support for the Keymile suen3 board which
>> is based on the Marvell Kirkwood (88F6281) SoC. As this
>> is a variant of the mgcoge2_arm_p1a board, this board
>> also uses common code stored in board/keymile/km_arm/km_arm.c
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> ---
>> - changes since v1:
>>   added comments from Wolfgang Denk:
>>   get rid of flash_info_t define in board config
>>   (to get this working patch 1/2 is introduced/needed)
>>
>> - changes since v2:
>>   added comments from Wolfgang Denk
>>   - rearranged if/else in do_spi_toggle()
>>   - added I/O accessor functions for bootcounter
>>
>> - changes since v3:
>>   added comment Scott Wood
>>   - removed nand_init in do_spi_toggle()
>>
>>   added comments from Prafulla Wadagaskar
>>   - km-arm.h renamed to km_arm.h
>>   - reworked eeprom_write_enable() (deleted it)
>>     (when reviewing this function, it cropped up, that
>>      this pin is connected through a gpio pin, not as
>>      in previous version, through the boco (a FPGA))
>>   - moved set_sda(), set_scl(), get_sda(), get_scl()
>>     to km_arm.c
>>   - split patch in 4 patches (for each board an extra patch)
>>   - renamed sdramregs.txt in kwbimage.cfg, also license
>>     info added.
>>
>>  MAINTAINERS             |    1 +
>>  MAKEALL                 |    1 +
>>  Makefile                |    3 +
>>  include/configs/suen3.h |  103
> 
> There is some code in earlier patch (i.e 1/4) for this board support that should reflect here.
> This gives better understanding

Hmm.. or I should better make the suen3 port as the first patch,
and the other board revisions as follow ups ... ?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

      reply	other threads:[~2010-02-15  8:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-12  8:05 [U-Boot] [PATCH 2/4 v4] arm: add support for the suen3 board from keymile Heiko Schocher
2010-02-13  5:16 ` Prafulla Wadaskar
2010-02-15  8:08   ` Heiko Schocher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7900F9.3030600@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.