All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev
Date: Mon, 15 Feb 2010 13:24:50 +0100	[thread overview]
Message-ID: <4B793D12.7010901@redhat.com> (raw)
In-Reply-To: <20100215092401.GA12082@amit-x200.redhat.com>

On 02/15/10 10:24, Amit Shah wrote:
>> Is there a qdev property for max_nr_ports?  Then simply adding a compat
>> property will do the trick.
>
> Something like this (I can split it into two patches before submission):

Yep, should be splitted.

> diff --git a/hw/pc.c b/hw/pc.c
> index 5b29f3b..a975934 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -1055,12 +1055,32 @@ void cmos_set_s3_resume(void)
>   }
>
>   static QEMUMachine pc_machine = {
> +    .name = "pc-0.13",
> +    .alias = "pc",
> +    .desc = "Standard PC",
> +    .init = pc_init_pci,
> +    .is_default = 1,
> +    .max_cpus = 255,
> +};
> +
> +static QEMUMachine pc_machine_v0_12 = {
>       .name = "pc-0.12",
>       .alias = "pc",

.alias should be dropped too.

cheers,
   Gerd

  parent reply	other threads:[~2010-02-15 12:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-12 13:42 [Qemu-devel] [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev Michael S. Tsirkin
2010-02-12 14:23 ` [Qemu-devel] " Amit Shah
2010-02-15  9:03   ` Gerd Hoffmann
2010-02-15  9:24     ` Amit Shah
2010-02-15 10:21       ` Michael S. Tsirkin
2010-02-15 12:24       ` Gerd Hoffmann [this message]
2010-02-15 13:21 ` Amit Shah
2010-02-15 14:07   ` Michael S. Tsirkin
2010-02-15 15:36     ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B793D12.7010901@redhat.com \
    --to=kraxel@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.