From: Roel Kluin <roel.kluin@gmail.com>
To: Matthew Dharm <mdharm-usb@one-eyed-alien.net>,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] USB: misplaced parenthesis
Date: Mon, 15 Feb 2010 23:40:09 +0100 [thread overview]
Message-ID: <4B79CD49.8070607@gmail.com> (raw)
The parenthesis was misplaced
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Is this maybe, as the comment states, why blanking a cdrw at speed 4
was unreliable?
diff --git a/drivers/usb/storage/shuttle_usbat.c b/drivers/usb/storage/shuttle_usbat.c
index b62a288..b958db5 100644
--- a/drivers/usb/storage/shuttle_usbat.c
+++ b/drivers/usb/storage/shuttle_usbat.c
@@ -1645,8 +1645,8 @@ static int usbat_hp8200e_transport(struct scsi_cmnd *srb, struct us_data *us)
if ((result = usbat_write_block(us,
USBAT_ATA, srb->cmnd, 12,
- (srb->cmnd[0]==GPCMD_BLANK ? 75 : 10), 0) !=
- USB_STOR_TRANSPORT_GOOD)) {
+ (srb->cmnd[0]==GPCMD_BLANK ? 75 : 10), 0)) !=
+ USB_STOR_TRANSPORT_GOOD) {
return result;
}
next reply other threads:[~2010-02-15 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 22:40 Roel Kluin [this message]
2010-02-15 22:44 ` [PATCH] USB: misplaced parenthesis Joe Perches
2010-02-16 11:16 ` Roel Kluin
2010-02-16 15:52 ` Alan Stern
2010-02-17 10:50 ` Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B79CD49.8070607@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.