From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NhMJX-000434-2u for mharc-grub-devel@gnu.org; Tue, 16 Feb 2010 07:14:03 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NhMJV-00042P-My for grub-devel@gnu.org; Tue, 16 Feb 2010 07:14:01 -0500 Received: from [140.186.70.92] (port=49036 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NhMJU-00041o-Vf for grub-devel@gnu.org; Tue, 16 Feb 2010 07:14:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NhMJU-0000FB-K2 for grub-devel@gnu.org; Tue, 16 Feb 2010 07:14:00 -0500 Received: from mail-bw0-f219.google.com ([209.85.218.219]:53071) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NhMJU-0000Ev-Ao for grub-devel@gnu.org; Tue, 16 Feb 2010 07:14:00 -0500 Received: by bwz19 with SMTP id 19so3846502bwz.8 for ; Tue, 16 Feb 2010 04:13:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=urnU8CTt0xtO6Fsi5eM8E4ALmXOYxW2rMur7rXtIuHM=; b=i0Ta2+anFtSRqgfuXPSjBh4U/QsbwJokVAb21LVWCGhYroFLxQBLmCfrbcK/CquBIF SpNGKh1r5FvKYH4kpZx/uSd+/TVgodP4Won04by63f5A3/0ndvm/AyXTq81JTFGIbmx3 VoKYcF9FaljeiPCju335fJx2qZE4Nh9rXhLwQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=fvowO9FNda+inZ3cwt+27Y+np1bKlYSyy3uZ6VcV3PPWZIjJ29FBVm2reMO4P7u2V4 98HdQvIxQadKsC2WMlC6QPkl4rHSF6hjNQwej6HZ0+HbZ2qtmg1M0Vp3LdosL/LdlRtS VUdNQ9L4ME4EmHNS1pFNoD+oAIB940kc9QIPg= Received: by 10.204.38.65 with SMTP id a1mr2116086bke.168.1266322439321; Tue, 16 Feb 2010 04:13:59 -0800 (PST) Received: from debian.bg45.phnet ([81.62.76.105]) by mx.google.com with ESMTPS id 16sm3110633bwz.3.2010.02.16.04.13.57 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 16 Feb 2010 04:13:58 -0800 (PST) Message-ID: <4B7A8BFA.2080307@gmail.com> Date: Tue, 16 Feb 2010 13:13:46 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <14260026.21265984443856.JavaMail.root@wombat> In-Reply-To: <14260026.21265984443856.JavaMail.root@wombat> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig612E9BDBA49D89858F4187C7" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [patch] GRUB possible patches X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 12:14:02 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig612E9BDBA49D89858F4187C7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable gburanov@gmail.com wrote: > Hello,=20 > > =20 >> It is. Can you write a ChangeLog entry? >> =20 > Done > > =20 First part applied >> ;1 is so called version. Basically all terminating ; have to = be >> stripped but only if filename doesn't come from rockridge or joliet. >> Apparently nobody uses grub2 on non-rockridge, non-joliet iso. While >> this bug should be fixed using grub from plain iso isn't supported due= >> to filename length limitation. >> =20 > > I found out that I got versioning even on joliet CD. I created CD using= "Small CD Writer". You can try the same. I created patch for that as wel= l, but of course you can skip it. > =20 Please don't put unrelated patches into single file. Fast look on the joliet.c of mkisofs suggests that it's not the case for its joliet. It seems there is more to it. Can you find some normative documents? > Regards, > Georgy > > PS: My Patch > > =3D=3D=3D modified file 'ChangeLog' > --- ChangeLog 2010-02-10 19:27:12 +0000 > +++ ChangeLog 2010-02-12 14:14:46 +0000 > @@ -1,3 +1,8 @@ > +2010-02-12 Georgy Buranov > + > + * disk/efi/efidisk.c (grub_efidisk_get_device_name): Fix bug obtainin= g device name of the whole disk > + * fs/iso9660.c (grub_iso9660_iterate_dir): Remove file versions from = ISO9660&Joliet file names > + > 2010-02-10 Vladimir Serbinenko > =20 > Pass SIMPLE framebuffer size in bytes and not 64K blocks. > > =3D=3D=3D modified file 'disk/efi/efidisk.c' > --- disk/efi/efidisk.c 2010-01-20 08:12:47 +0000 > +++ disk/efi/efidisk.c 2010-02-12 14:05:23 +0000 > @@ -825,7 +825,7 @@ > if (! disk) > return 1; > =20 > - if (disk->id =3D=3D GRUB_DISK_DEVICE_EFIDISK_ID) > + if (disk->dev->id =3D=3D GRUB_DISK_DEVICE_EFIDISK_ID) > { > struct grub_efidisk_data *d; > =20 > > =3D=3D=3D modified file 'fs/iso9660.c' > --- fs/iso9660.c 2010-01-27 03:11:20 +0000 > +++ fs/iso9660.c 2010-02-12 14:13:01 +0000 > @@ -615,9 +615,6 @@ > if (!filename) > { > name[dirent.namelen] =3D '\0'; > - filename =3D grub_strrchr (name, ';'); > - if (filename) > - *filename =3D '\0'; > =20 > if (dirent.namelen =3D=3D 1 && name[0] =3D=3D 0) > filename =3D "."; > @@ -640,6 +637,14 @@ > =20 > filename_alloc =3D 1; > } > + =20 > + if (!dir->data->rockridge) > + { > + // On simple ISO 9660 disks and on joliet, we need to remove file = version, if any > =20 We use only C-style comments > + char* lastSymbol =3D grub_strrchr (filename, ';'); > + if (lastSymbol) > + *lastSymbol =3D '\0'; > + } =20 > =20 > if (hook (filename, type, node)) > { > > > > -- > This message was sent on behalf of gburanov@gmail.com at openSubscriber= =2Ecom > http://www.opensubscriber.com/message/grub-devel@gnu.org/13415591.html > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig612E9BDBA49D89858F4187C7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAkt6jAEACgkQNak7dOguQgmdTAEAq5ZepifiYm6gDRSJiFSPGmhN ZQAKZIl//amXTPC7P2UA/3v0fnT51QGVmYGwHLPg2RlHQpd66N2lGLpvWPOn/taN =0pm+ -----END PGP SIGNATURE----- --------------enig612E9BDBA49D89858F4187C7--