From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NhNjb-00048U-90 for mharc-grub-devel@gnu.org; Tue, 16 Feb 2010 08:45:03 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NhNjZ-00047D-77 for grub-devel@gnu.org; Tue, 16 Feb 2010 08:45:01 -0500 Received: from [140.186.70.92] (port=46210 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NhNjX-00045Q-75 for grub-devel@gnu.org; Tue, 16 Feb 2010 08:45:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NhNjW-0004bE-H6 for grub-devel@gnu.org; Tue, 16 Feb 2010 08:44:59 -0500 Received: from fg-out-1718.google.com ([72.14.220.156]:18969) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NhNjW-0004b1-80 for grub-devel@gnu.org; Tue, 16 Feb 2010 08:44:58 -0500 Received: by fg-out-1718.google.com with SMTP id e12so840832fga.12 for ; Tue, 16 Feb 2010 05:44:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=p5QKUdLRXBL5HT9HIfS6UxN9gzjvabgMBrhDAwLJHf8=; b=Ify3fE1oPVR3uTLp79eSIaruaTSIqXzF9zfsM7PARplaYCHjAR0Si+8Pwp0BoqqdJ1 b5ZWoqkj+gIKTIEpXHfkep17tP7nA2mxSmvVQovRd0JSl05+9yM8NHlDhM9zaUrXkz7F C3YZtxtxSPFPzD3Nvibms020GkY6oQZ0/ht+A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=iMcj0x/rT/hMb76VV56NrfMNZqVuM34ivDd4WmnH/pzAiHYJg2RiHZekcvnM1JHIld r/B3jGIVL8QBmYJjs2m7ASO21jOc7yPqIiGyr48MnAMLnHaV1e6JSGANvXfE1xIJ/It1 qxazmnJhi9lUUT797QPNkCmx+CdeNKIgkaOsk= Received: by 10.86.126.9 with SMTP id y9mr11662834fgc.12.1266327895798; Tue, 16 Feb 2010 05:44:55 -0800 (PST) Received: from debian.bg45.phnet ([81.62.76.105]) by mx.google.com with ESMTPS id e3sm8919192fga.16.2010.02.16.05.44.54 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 16 Feb 2010 05:44:55 -0800 (PST) Message-ID: <4B7AA14D.507@gmail.com> Date: Tue, 16 Feb 2010 14:44:45 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <201002042201.17127.szymon@janc.net.pl> , <4B7A99A4.6090806@gmail.com> <835ef9791a743a0bc02df541c23d7ae6@webmail.rootnode.net> In-Reply-To: <835ef9791a743a0bc02df541c23d7ae6@webmail.rootnode.net> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig85D280A11F13596AFE4B551A" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH][UPDATED] support for xz compression format X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 13:45:01 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig85D280A11F13596AFE4B551A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Szymon Janc wrote: > On Tue, 16 Feb 2010 14:12:04 +0100 Vladimir '=CF=86-coder/phcoder' Ser= binenko=20 > wrote > > =20 >> First of all: could you use unified diff? (-u option) >> =20 > > Sure, will use that in future. > > =20 >> grub2-1.98~experimental.20100120/conf/xzembed.rmk >> I don't see a need for either separate .rmk or separate module >> >> + static grub_uint8_t inbuf[XZBUFSIZ]; >> + static grub_uint8_t outbuf[XZBUFSIZ]; >> Avoid static variables. It will fail if user e.g. mounts xz file as a >> loopback then opens xz'ed file on this loopback. Just put buffers in >> grub_xzio >> + if (! file) >> + { >> + grub_error (GRUB_ERR_OUT_OF_MEMORY, "out of memory"); >> + return 0; >> grub_error is already issued by grub_malloc, no need to put the same >> code here. >> =20 > > I think You have reviewed old patch, not the updated one :-) > > =20 Right. Many comments still apply though. Reviewing new one (in addition to old comments): + #define VLI_MAX_DIGITS 9 Are you sure it's 9? It gives only 63 and not 64 bits + if (! test_header(file) || ! test_footer(file)) + { Seeking to the end of file is very expensive on pxe. Can it be skipped? grub_xzio_read seems to ignore file->offset. Have you tested seeking? > -----------------------------------------------------------------------= - > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig85D280A11F13596AFE4B551A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF0EAREKAAYFAkt6oVMACgkQNak7dOguQglKLwEAg9zbskP7ZzOsGlWfK3WCyA83 TvxfHwhar3JCIlRbQ4YA+PU0VPf/dQeRQ629MFR2qrpzC/THAQ+srvga1emrPbc= =gPPL -----END PGP SIGNATURE----- --------------enig85D280A11F13596AFE4B551A--