From: jim owens <owens6336@gmail.com>
To: Chris Mason <chris.mason@oracle.com>,
Josef Bacik <josef@redhat.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH V2] Btrfs: Full direct I/O and AIO read implementation.
Date: Tue, 16 Feb 2010 12:09:34 -0500 [thread overview]
Message-ID: <4B7AD14E.9050801@gmail.com> (raw)
In-Reply-To: <20100216160107.GF3497@think>
Chris Mason wrote:
> [ use i_mutex for reads? ]
>
> But, we already need the code that btrfs_page_mkwrite uses. It should
> be enough to wait for the ordered extents and have the extent range
> locked.
You don't mean have the lock_extent active while I issue the
btrfs_wait_ordered_range as I found that was a deadlock when
I tried it before. AFAICS without i_mutex I have to do this
all unlocked and hope they are not being stupid.
> The cost of i_mutex on parallel readers + high speed devices can be
> surprising.
OK, I did not have i_mutex until the very last days of coding when
I could not find any way to fix my problems. I'll see if I can
come up with something that makes Josef think my vector code is
pretty by comparison ;)
jim
next prev parent reply other threads:[~2010-02-16 17:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 18:53 [PATCH V2] Btrfs: Full direct I/O and AIO read implementation jim owens
2010-02-12 19:28 ` Josef Bacik
2010-02-14 1:30 ` jim owens
2010-02-15 16:42 ` Chris Mason
2010-02-15 19:18 ` jim owens
2010-02-16 16:01 ` Chris Mason
2010-02-16 17:09 ` jim owens [this message]
2010-02-15 21:58 ` Christoph Hellwig
2010-02-15 22:26 ` jim owens
2010-02-15 22:32 ` Christoph Hellwig
2010-02-15 22:40 ` jim owens
2010-02-16 15:49 ` Chris Mason
2010-02-15 22:01 ` rk
2010-02-15 22:31 ` jim owens
2010-02-16 19:28 ` jim owens
2010-02-16 19:39 ` Josef Bacik
2010-03-03 18:54 ` jim owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7AD14E.9050801@gmail.com \
--to=owens6336@gmail.com \
--cc=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.