From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932964Ab0BPRip (ORCPT ); Tue, 16 Feb 2010 12:38:45 -0500 Received: from terminus.zytor.com ([198.137.202.10]:59288 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756860Ab0BPRio (ORCPT ); Tue, 16 Feb 2010 12:38:44 -0500 Message-ID: <4B7AD802.1090508@zytor.com> Date: Tue, 16 Feb 2010 09:38:10 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1 MIME-Version: 1.0 To: Oleg Nesterov CC: Linus Torvalds , Andrew Morton , Andi Kleen , Roland McGrath , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] x86: set_personality_ia32() abuses TS_COMPAT References: <20100215161752.GA19962@redhat.com> <4B799C3F.7010308@zytor.com> <20100215194123.96D49FC3@magilla.sf.frob.com> <4B79B202.5090006@zytor.com> <20100216101903.GA1057@redhat.com> <20100216102332.GL21783@one.firstfloor.org> <20100216140126.GA16448@redhat.com> <20100216140242.GC16448@redhat.com> <20100216171614.GA23503@redhat.com> In-Reply-To: <20100216171614.GA23503@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/16/2010 09:16 AM, Oleg Nesterov wrote: > > The only reason I dislike TS_COMPAT is that I spent a lot of time > trying to understand the necessity to set it here when I tried to > understand the basics of compat issues. > Just to throw something else into here... please also keep in mind that there is value to the notion of keeping a software invariant true. In this case, even if setting TS_COMPAT doesn't do anything *right now*, it helps maintain an invariant which might avoid bugs in the future. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.