From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NhRyM-0003ya-QH for mharc-grub-devel@gnu.org; Tue, 16 Feb 2010 13:16:34 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NhRyL-0003xw-J9 for grub-devel@gnu.org; Tue, 16 Feb 2010 13:16:33 -0500 Received: from [140.186.70.92] (port=58711 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NhRyK-0003xB-Lk for grub-devel@gnu.org; Tue, 16 Feb 2010 13:16:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NhRyK-0008OD-2X for grub-devel@gnu.org; Tue, 16 Feb 2010 13:16:32 -0500 Received: from mail-bw0-f219.google.com ([209.85.218.219]:64826) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NhRyJ-0008O5-SR for grub-devel@gnu.org; Tue, 16 Feb 2010 13:16:32 -0500 Received: by bwz19 with SMTP id 19so4218341bwz.8 for ; Tue, 16 Feb 2010 10:16:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=6MiN73Z6WuBrH++egPnQp0GztcaErI9TXpKAGFCfwr4=; b=VIAsfRoIEDI6DEIdYJYsXdvNtOycPEITZacBab12tBabk5QMPcY1Fv7zAkSTYTttWi Imb1hG8XiMdEPcurBtHx8G+R75L7ADFtRwtvINhB8d1SACTV2tvgh5IjAyPBxAEA95Xj mMatvdTN43YoQIxPU9heSv2zR9nev5kWRuv9c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=B63Kmxz74hTSkhP/vio04JWwJy8Z2tE3fPSJUEerwUYrjvCsTfx/HKSJRDAKQevFGO 9fixzVCQ+3JcT6vM2WXJveCBdeGAnuxmY/J1Z34NMdc+EdbQK8PymKApQaDJXJm0U7iX iQQ+tS8kzZIXUhWix1fcvKNnVMeeZGkMb0KSE= Received: by 10.204.25.194 with SMTP id a2mr398428bkc.191.1266344187642; Tue, 16 Feb 2010 10:16:27 -0800 (PST) Received: from debian.bg45.phnet ([81.62.76.105]) by mx.google.com with ESMTPS id 14sm3258070bwz.1.2010.02.16.10.16.26 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 16 Feb 2010 10:16:26 -0800 (PST) Message-ID: <4B7AE0F3.1000706@gmail.com> Date: Tue, 16 Feb 2010 19:16:19 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <201002161906.07800.szymon@janc.net.pl> In-Reply-To: <201002161906.07800.szymon@janc.net.pl> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig6ACAB98134F1E3AABB83845B" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] transparent file reader X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 18:16:33 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6ACAB98134F1E3AABB83845B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Szymon Janc wrote: > Hello, > > Attached patch makes file reader transparent. It should make adding new= filters=20 > to file reader easier. > > - gzio.h is gone > - gzio is no more transparent, transparency is handled in grub_file_ope= n() > - renamed GRUB_ERR_BAD_GZIP_DATA to GRUB_ERR_BAD_IOFILTER_DATA, it will= be > used by other ios like xzio > > =20 I like the patch however few comments: 1) How are filters ordered? 2) How would I selectively disable a filter. E.g. for hexdump or when payload expects compressed data? +/* Registered filters list. */ +static grub_io_filter_t grub_io_filter_list =3D NULL; + +void grub_io_register(grub_io_filter_t filter) +{ + filter->next =3D grub_io_filter_list; + grub_io_filter_list =3D filter; +} + list.h can be used for this. > What do You think about it? > > > =20 > -----------------------------------------------------------------------= - > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig6ACAB98134F1E3AABB83845B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAkt64PkACgkQNak7dOguQgnNpgD/Y9VvV7TNRaMi51etzvYIre+l te/TML2orNv2U27xjyQA/3uGQgNFN0zxrEECCltj4STbqKCh2RAyMRtBBxh5wSgT =inu4 -----END PGP SIGNATURE----- --------------enig6ACAB98134F1E3AABB83845B--