All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Andreas Dilger <adilger@sun.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
	ext4 development <linux-ext4@vger.kernel.org>,
	Shuichi Ihara <ihara@sun.com>
Subject: Re: [PATCH] mk2fs lazy_journal_init option
Date: Tue, 16 Feb 2010 17:21:32 -0600	[thread overview]
Message-ID: <4B7B287C.2030105@redhat.com> (raw)
In-Reply-To: <4B7B2619.8060106@redhat.com>

Eric Sandeen wrote:

> Haven't dug all the way through it but I think this is another
> in the saga of blk_t vs. blk64_t.  This seems to fix (?) it:
> 
> --- a/lib/ext2fs/mkjournal.c
> +++ b/lib/ext2fs/mkjournal.c
> @@ -218,7 +218,7 @@ struct mkjournal_struct {
>  };
> 
>  static int mkjournal_proc(ext2_filsys  fs,
> -                          blk_t        *blocknr,
> +                          blk64_t      *blocknr,
>                            e2_blkcnt_t  blockcnt,
>                            blk_t        ref_block EXT2FS_ATTR((unused)),
>                            int          ref_offset EXT2FS_ATTR((unused)),
> 
> though I doubt that is correct/complete.

Humm my git tree is not what I thought it was, the above might be a
wild goose chase, sorry.

-Eric

  reply	other threads:[~2010-02-16 23:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-10 11:44 [PATCH] mk2fs lazy_journal_init option Andreas Dilger
2010-02-16 22:15 ` Andreas Dilger
2010-02-16 23:11   ` Eric Sandeen
2010-02-16 23:21     ` Eric Sandeen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-02-19 19:53 number9652
2010-02-24  5:30 ` Andreas Dilger
2010-03-02 19:36   ` Nic Case

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7B287C.2030105@redhat.com \
    --to=sandeen@redhat.com \
    --cc=adilger@sun.com \
    --cc=ihara@sun.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.