From: Stephen Boyd <bebarino@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>
Subject: Re: [PATCHv3] Documentation: describe --thin more accurately
Date: Thu, 18 Feb 2010 00:33:16 -0800 [thread overview]
Message-ID: <4B7CFB4C.2020507@gmail.com> (raw)
In-Reply-To: <7vfx52xm8d.fsf@alter.siamese.dyndns.org>
On 02/15/2010 12:44 PM, Junio C Hamano wrote:
> I however think the first two points might be better covered by the
> description of `--thin` of `pack-objects` and we should simply refer to it
> from here, like this:
>
> --fix-thin::
> Make a "thin" pack produced by `git pack-objects --thin` (see
> linkgit:git-pack-objects[1] for details) directly usable by
> git, by adding objects that the objects stored in the
> deltified form are based on to the packfile.
>
This looks good. I'd like to avoid introducing the term packfile though
and just use pack throughout.
> --thin::
> Create a "thin" pack in order to reduce network transfer.
> +
> For a packfile to be usable directly by git, any object in the pack
> that is represented in the deltified form must be based on an object
> that exists in the same pack. Such a pack is called "self-contained".
> +
> If the sender sends an object in the deltified form based on an object
> both the sender and the receiver have, but excludes the common object
> itself from the datastream, it can often reduce the network traffic
> dramatically. Such a datastream is called a "thin" pack.
> +
> Note that a thin pack violates the self-containedness requirement and
> is not directly usable by git on the receiving end without making it a
> self-contained pack by running `git index-pack --fix-thin` (see
> linkgit:git-index-pack[1]).
This looks long winded. Perhaps we can do without explaining what
self-containedness is? If you read the second paragraph in the
description section of git-pack-objects.txt it tries to explain
self-contained:
The packed archive format (.pack) is designed to be
self-contained so that it can be unpacked without
any further information
If all I know is a pack contains objects and deltas based on other
objects I might be able to figure out that all the objects must be
present in the pack for it to be self-contained. This description
section might need some work but I don't think repeating ourselves in
--thin is good.
Updated patch to follow.
next prev parent reply other threads:[~2010-02-18 8:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 5:14 [PATCH] Documentation: reword --thin description Stephen Boyd
2010-02-10 16:07 ` Nicolas Pitre
2010-02-10 16:52 ` Stephen Boyd
2010-02-10 18:59 ` Junio C Hamano
2010-02-10 21:04 ` Nicolas Pitre
2010-02-12 8:00 ` [PATCHv2] Documentation: describe --thin more accurately Stephen Boyd
2010-02-12 17:36 ` Junio C Hamano
2010-02-15 19:33 ` [PATCHv3] " Stephen Boyd
2010-02-15 20:44 ` Junio C Hamano
2010-02-18 8:33 ` Stephen Boyd [this message]
2010-02-18 9:10 ` [PATCHv4] " Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7CFB4C.2020507@gmail.com \
--to=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.