From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758351Ab0BRRPJ (ORCPT ); Thu, 18 Feb 2010 12:15:09 -0500 Received: from terminus.zytor.com ([198.137.202.10]:60051 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758021Ab0BRRPG (ORCPT ); Thu, 18 Feb 2010 12:15:06 -0500 Message-ID: <4B7D7552.2010001@zytor.com> Date: Thu, 18 Feb 2010 09:13:54 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1 MIME-Version: 1.0 To: "Eric W. Biederman" CC: Yinghai Lu , Ingo Molnar , Thomas Gleixner , Andrew Morton , Rusty Russell , Suresh Siddha , linux-kernel@vger.kernel.org, Jeremy Fitzhardinge Subject: Re: [RFC PATCH 3/3] genericirq: change ack/mask in irq_chip to take irq_desc in addition to irq References: <1266029390-30907-1-git-send-email-yinghai@kernel.org> <4B7676BB.8030608@kernel.org> <4B772A54.1000000@kernel.org> <4B773CEB.9010609@kernel.org> <4B7CA9A1.3020806@kernel.org> <4B7CAAEC.1000608@kernel.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/18/2010 09:04 AM, Eric W. Biederman wrote: > > May I ask why these methods and why pass both irq and desc instead of > just desc? > > I think in the long run passing both irq and desc through several > functions may incur some maintenance cost that it would be nice not to > pay (register pressure and increased chance of typos). > Indeed; if the IRQ number is needed the function should just get it from desc->irq. -hpa