From: Johannes Sixt <j6t@kdbg.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
Mark Brown <broonie@sirena.org.uk>
Subject: Re: [RFC/PATCH 0/3] git-gui: Don’t trigger garbage collection warning so easily
Date: Thu, 18 Feb 2010 21:40:55 +0100 [thread overview]
Message-ID: <4B7DA5D7.20704@kdbg.org> (raw)
In-Reply-To: <20100218143431.GA30486@progeny.tock>
Jonathan Nieder schrieb:
> This series does the simplest thing I could figure out how to
> implement: it builds in the heuristic for counting loose objects from
> builtin-gc.c into git-gui (so it will respect the gc.auto
> configuration and by default will trigger much less often) and if that
> heuristic is satisfied, runs gc --auto.
Any improvement in this respect is appreciated.
Minor nit: By all means while you are in this area, please do not carry
over this silly "your repository has *approximately* 576 objects" message
(highlight is mine). "576" is not approximate. "500" is approximate, "750"
is, too, but "1024" etc. is not. ;-)
-- Hannes
prev parent reply other threads:[~2010-02-18 20:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 14:34 [RFC/PATCH 0/3] git-gui: Don’t trigger garbage collection warning so easily Jonathan Nieder
2010-02-18 14:35 ` [PATCH 1/3] git-gui: factor out too_many_loose_objects routine from hint_gc Jonathan Nieder
2010-02-18 14:39 ` [PATCH/RFC 2/3] git-gui: Do not hold the user hostage with a full gc at startup Jonathan Nieder
2010-02-18 14:41 ` [PATCH/RFC 3/3] git-gui: Do not suggest a gc if gc --auto would not do it Jonathan Nieder
2010-02-18 15:49 ` Jonathan Nieder
2010-02-18 20:40 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7DA5D7.20704@kdbg.org \
--to=j6t@kdbg.org \
--cc=broonie@sirena.org.uk \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.