All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: George Karavaev <george.karavaev@astc-design.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Added Cortex_a8_v3 version, and added a shift instruction for NEON.
Date: Fri, 19 Feb 2010 07:52:51 -0800	[thread overview]
Message-ID: <4B7EB3D3.70507@twiddle.net> (raw)
In-Reply-To: <4B7DD393.7070809@astc-design.com>

On 02/18/2010 03:56 PM, George Karavaev wrote:
> +                            tmp64 = tcg_temp_new_i64();
> +                            tcg_gen_movi_i64(tmp64, 0);
> +                            tcg_gen_not_i64(tmp64, tmp64);

movi -1?

> +                            gen_helper_neon_shl_u64(tmp64, tmp64, cpu_V1);
> +                            tcg_gen_and_i64(cpu_V0, cpu_V0, tmp64); /*
> XXX */

Why the XXX?

> +                            tcg_gen_not_i64(tmp64, tmp64);
> +                            tcg_gen_and_i64(cpu_V1, cpu_V1, tmp64);

tcg_gen_andc_i64.


r~

  reply	other threads:[~2010-02-19 15:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-18 23:56 [Qemu-devel] [PATCH] Added Cortex_a8_v3 version, and added a shift instruction for NEON George Karavaev
2010-02-19 15:52 ` Richard Henderson [this message]
2010-03-03  0:33   ` [Qemu-devel] " George Karavaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7EB3D3.70507@twiddle.net \
    --to=rth@twiddle.net \
    --cc=george.karavaev@astc-design.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.